Remove overflow-x: hidden from body #5890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's known that when body has overflow-x: hidden - scroll handler on window doesn't handle scroll events. We recommend users of the library to apply this manually is they need.
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1b4176d:
|
e2e tests |
👀 Docs deployed
Commit 1b4176d |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5890 +/- ##
=======================================
Coverage 81.20% 81.20%
=======================================
Files 299 299
Lines 9200 9200
Branches 3128 3128
=======================================
Hits 7471 7471
Misses 1729 1729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Oct 2, 2023
BlackySoul
approved these changes
Oct 2, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 2, 2023
Известно, что при `overflow-x: hidden` на `body` события скролла не всплывают до `window`. И библиотеки (реализующие виртуальные списки), которые слушают события скролла `window` ломаются. Рекоммендуем пользователям библиотеки самим выставлять `overflow-x: hidden` на `body`, если это действительно нужно по какой-то причине. Возможно, что выставим это же на `AppRoot`, если в этом будет необходимость, как в `embedded` режиме.
|
✅ v5.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Известно, что при
overflow-x: hiddenнаbodyсобытия скролла не всплывают доwindow. И библиотеки (реализующие виртуальные списки [react-virtualizer]), которые слушают события скроллаwindowломаются.Рекоммендуем пользователям библиотеки самим выставлять
overflow-x: hiddenнаbody, если это действительно нужно по какой-то причине.Возможно, что выставим это же на
AppRoot, если в этом будет необходимость, как вembeddedрежиме.