Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reexport PlacementWithAuto as FloatingPlacementWithAuto #7810

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Oct 22, 2024


  • Release notes

Описание

Есть случаи, когда тип экспортируют через @vkontakte/vkui/dist/lib/floating

Release notes

Улучшения

  • Добавлен экспорт типа FloatingPlacementWithAuto

@inomdzhon inomdzhon requested a review from a team as a code owner October 22, 2024 13:34
@inomdzhon inomdzhon self-assigned this Oct 22, 2024
@inomdzhon inomdzhon added this to the v7.0.0-beta.1 milestone Oct 22, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 380.52 KB (0%)
JS (gzip) 115.34 KB (0%)
JS (brotli) 94.99 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.94 KB (0%)
CSS (gzip) 42.06 KB (0%)
CSS (brotli) 33.16 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c39f486

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (43a6605) to head (c39f486).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7810   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         376      376           
  Lines       11074    11074           
  Branches     3677     3677           
=======================================
  Hits        10530    10530           
  Misses        544      544           
Flag Coverage Δ
unittests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 41c0684 into master Oct 22, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/reexport-PlacementWithAuto branch October 22, 2024 15:49
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.1 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.1, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants