Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

noch3d
Copy link
Contributor

@noch3d noch3d commented Dec 13, 2022

Spanish translation of the vrcbce. It remplace all the english text to spanish but the texts can be used to make an translation button in the prefab.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


c.chon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@FairlySadPanda FairlySadPanda requested review from FairlySadPanda and Metamaniac and removed request for FairlySadPanda December 13, 2022 12:05
Copy link
Contributor

@Legoman99573 Legoman99573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I see nothing wrong with this, but I assume it would be better to re-write all prompts to pull from a single txt file and setup for multiple languages. I do like the idea of making translations for multiple languages a possibility down the road.

@FairlySadPanda
Copy link
Collaborator

Hi, sorry for taking so long to address this PR.

Thanks for this translation!

We can't merge in a translation at the moment for any language. We don't have a way of supporting multiple languages so it would be very likely that this code would not be updated properly as we fix bugs and add features.

This work will be very useful when we do add language support, which will be in the big rewrite later this year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants