Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerhub discontinues free support #37

Closed
nilsnolde opened this issue Jun 8, 2021 · 8 comments
Closed

Dockerhub discontinues free support #37

nilsnolde opened this issue Jun 8, 2021 · 8 comments

Comments

@nilsnolde
Copy link
Collaborator

Next one bites the dust.. Got an email from Dockerhub telling me that auto-builds will not be support from 18.06. on, which would "break" our release system here. One alternative would be to join their "Docker Open Source program". Another to set up the release system on Github Actions.

@jcoupey?

@jcoupey
Copy link
Contributor

jcoupey commented Jun 9, 2021

I tried to go the "open source program" way for the core repo CI builds after the Travis change and in that case frankly that was quite a waste of time.

Does this only affects building the images or making them available for downstream users?

@nilsnolde
Copy link
Collaborator Author

I'm really skeptical with an "open source program" from any org, and suspect a similar waste of time.

It affects only building the images. Although docker recently also limited unauthenticated access to images, but (for now) with a fairly high limit. We can build the image in GH actions, then push them to dockerhub and/or github packages. I'd stay on dockerhub for the time being, least hassle for existing users (and future ones really).

But yeah, the next release will probably not trigger an auto-build anymore. I'll raise a PR soon for GH actions, quickly done.

@jcoupey
Copy link
Contributor

jcoupey commented Aug 10, 2021

We can build the image in GH actions, then push them to dockerhub and/or github packages. I'd stay on dockerhub for the time being, least hassle for existing users (and future ones really).

So be it!

@nilsnolde
Copy link
Collaborator Author

nilsnolde commented Oct 5, 2021

@jcoupey I just a few mins and wanted to try github actions with the new rc . can you register the docker credentials in this repository as secrets and let me know the keys? I need them before I can push images there:

      - name: Log in to Docker Hub
        uses: docker/login-action@v1
        with:
          username: ${{ secrets.DOCKER_USERNAME }}
          password: ${{ secrets.DOCKER_PASSWORD }}

@nilsnolde
Copy link
Collaborator Author

or simply name the keys as in the example and give a heads-up when they're ready:)

@nilsnolde
Copy link
Collaborator Author

I'll also throw in a test so I don't have to do that manually anymore..

@jcoupey
Copy link
Contributor

jcoupey commented Oct 5, 2021

Ah, didn't know I could actually share secrets with GH... DOCKER_USERNAME and DOCKER_PASSWORD are set as repo secrets now.

@nilsnolde
Copy link
Collaborator Author

solved in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants