vroom with ORS instance on different base path than /ors not possible

[TheGreatRefrigerator]

Hi 👋🏻 ORS maintainer here,

currently the base path in the ors_wrapper.cpp is hardcoded to /ors/v2. While this is the default of a self-hosted ors instance,
the live API doesn't use the /ors base path and no connection to it or other instances without the default base path is possible.

The solution would be to remove the hardcoded /ors basepath in the ors_wrapper.cpp. (the v2 is still the default but will change to v3 as well at some point.)
Since the introduction of the host.path the base path can now be set dynamically in the conifg.yml of vroom-express or passed via cli passing <profile>:<host>/ors.
And with the introduced change this would need to be done for coupling with selfhosted ors instances with default settings.

[nilsnolde]

Important to note that this’ll break existing vroom/ORS users and they’ll need to append /ors now themselves. I highly doubt Julien would consider it a breaking change, but IMO this should be at least flagged in the changelog. Also vroom-express will need to get a new release with a new default config.yml to change the default host paths.

Good timing though with 1.14 being eminent apparently:)

[TheGreatRefrigerator]

but IMO this should be at least flagged in the changelog.

Agree! Will add to the changelog.

Also vroom-express will need to get a new release with a new default config.yml to change the default host paths.

I will add a PR that complements this.

[jcoupey]

I highly doubt Julien would consider it a breaking change

Hum right since it won't break anything for me. But users that suddenly get errors after upgrading might have a different opinion.

On the other hand if this is handled at the vroom-express level we should at least avoid complaints from the Docker users.

[TheGreatRefrigerator]

VROOM-Project/vroom-express#99 the complementing PR is ready

[jcoupey]

Merged in master with #1037. I also cherry-picked the changes to include them in the release/1.14 branch. This will be part of the second release candidate I have to tag anyway (includes a regression fix). I'll also merge the vroom-express PR and tag a release over there.