Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Line Comment Action Doesn't Work with ansible Language Mode #154

Closed
mattmonkey83 opened this issue Aug 13, 2018 · 5 comments
Closed

Comments

@mattmonkey83
Copy link

Environment

  • Extension version: 0.3.1
  • OS Type: MacOS

Summary

Add Line Comment (cmd+/) action no longer works when language mode is set to ansible.

Reproduce steps

Install extension
Set language mode to ansible
Attempt to use Add Line Comment action.

Expected Results

Current line or selected block should be commented using # character.

Actual Results

Nothing happens.

Switching language mode to YAML rectifies the problem but is far from ideal.
Assume the language definition is missing some configuration.

@yungezz
Copy link
Contributor

yungezz commented Aug 14, 2018

@mattmonkey83 thanks for reporting the issue, we're looking at it. will update if any finding.

@in-in
Copy link
Contributor

in-in commented Aug 18, 2018

Same on ctrl + /

  • vscoss.vscode-ansible@0.3.1
  • vscode: 1.26.1 x64
  • Linux Mint 19

It also does not work through the menu ctrl + shift + p
18081801

@yungezz
Copy link
Contributor

yungezz commented Aug 31, 2018

fixed by PR #155 . will be included in next release.

@mattmonkey83
Copy link
Author

Excellent. Thanks 🙂

@yungezz
Copy link
Contributor

yungezz commented Sep 13, 2018

fixed in release 0.4.0.

@yungezz yungezz closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants