Set black line-length to 120 characters #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default line-length in black is set to 88 characters, for rather arbitrary/historical reasons. Some weeks ago, we discussed about it in GHDL (since we use black for pyGHDL) and we agreed on setting it to 120 characters (ghdl/ghdl#1800). Hence, I'm proposing the same change here.
As seen in the file changes of this PR, the size of the code is reduced to 30% in terms of the number of lines.
Since some other PRs might be affected by this, we might want to keep it on hold and apply it right before a breaking release.