Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unite all configuration #775

Open
bencooper222 opened this issue Jan 2, 2021 · 0 comments
Open

Unite all configuration #775

bencooper222 opened this issue Jan 2, 2021 · 0 comments
Assignees
Labels
Priority: High Important Type: Enhancement New feature or request

Comments

@bencooper222
Copy link
Member

From what I can see, the big places to configure Vaken are

  • application.ts
  • constants.ts
  • strings.json

and I'm sure there is more that I'm missing in little lines in random files.

I don't think there's a reason to separate all configuration from code - that leads to complexity in another way but if we're going to have several files whose purpose is only config, I think we should try to at least get them in one directory (and as .ts files).

@leonm1 leonm1 added Priority: High Important Type: Enhancement New feature or request labels Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Important Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants