Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the actual type of char is different on different platforms #98

Closed
necuil opened this issue Apr 7, 2022 · 4 comments
Closed

the actual type of char is different on different platforms #98

necuil opened this issue Apr 7, 2022 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@necuil
Copy link

necuil commented Apr 7, 2022

On android devices, char is unsigned, unlike PC. In the function unique_ptr parse(const char *ptr, ParseMode &globalMode), it assigns the content of each byte to a variable of type short by accessing a char pointer. On android devices, this step can have unexpected results. So it should be int8_t not char.
16492300306567
And after I replace those "char" with "int8_t" or "uint8_t", vectorscan works fine on my android device.

@markos
Copy link

markos commented Apr 7, 2022

is this 32-bit arm or 64-bit arm? This is not a bad suggestion, I would not mind checking such a PR if you would be willing to submit one, but at the moment I cannot commit to working on this, as Android is not within the supported platforms yet. In fact, I could not think of a usecase for Android until now :)

@necuil
Copy link
Author

necuil commented Apr 7, 2022

both 32-bit arm and 64-bit arm

@markos markos added the enhancement New feature or request label Apr 18, 2022
@markos
Copy link

markos commented Sep 8, 2022

Hi @necuil, we are cleaning up some issues. Regarding Android and 32-bit Arm we have decided we will not support 32-bit arm at this moment and definitely not Android unless the changes are required are minimal and someone else submits a PR for this or funds this effort. Since the request was made already 6 months ago, it's already an old issue. I will be closing this issue as wontfix.

@markos markos closed this as completed Sep 8, 2022
@markos markos added wontfix This will not be worked on and removed enhancement New feature or request labels Sep 8, 2022
@markos markos reopened this Nov 2, 2022
@markos markos added bug Something isn't working and removed wontfix This will not be worked on labels Nov 17, 2022
@markos markos self-assigned this Nov 17, 2022
@markos markos added this to the 5.4.10 milestone Mar 23, 2023
@markos markos modified the milestones: 5.4.10, 5.4.11 Sep 5, 2023
@markos
Copy link

markos commented Nov 1, 2023

Closing this as arm is now a supported platform and works as expected.

@markos markos closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants