You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On android devices, char is unsigned, unlike PC. In the function unique_ptr parse(const char *ptr, ParseMode &globalMode), it assigns the content of each byte to a variable of type short by accessing a char pointer. On android devices, this step can have unexpected results. So it should be int8_t not char.
And after I replace those "char" with "int8_t" or "uint8_t", vectorscan works fine on my android device.
The text was updated successfully, but these errors were encountered:
is this 32-bit arm or 64-bit arm? This is not a bad suggestion, I would not mind checking such a PR if you would be willing to submit one, but at the moment I cannot commit to working on this, as Android is not within the supported platforms yet. In fact, I could not think of a usecase for Android until now :)
Hi @necuil, we are cleaning up some issues. Regarding Android and 32-bit Arm we have decided we will not support 32-bit arm at this moment and definitely not Android unless the changes are required are minimal and someone else submits a PR for this or funds this effort. Since the request was made already 6 months ago, it's already an old issue. I will be closing this issue as wontfix.
On android devices, char is unsigned, unlike PC. In the function unique_ptr parse(const char *ptr, ParseMode &globalMode), it assigns the content of each byte to a variable of type short by accessing a char pointer. On android devices, this step can have unexpected results. So it should be int8_t not char.
And after I replace those "char" with "int8_t" or "uint8_t", vectorscan works fine on my android device.
The text was updated successfully, but these errors were encountered: