Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-Request] Add more data, maybe add new functionality around new data #7

Open
jtrv opened this issue Feb 16, 2023 · 2 comments

Comments

@jtrv
Copy link

jtrv commented Feb 16, 2023

There is more data in this set that we can probably add to iching's output or access through different sub-commands or flags etc.

The most interesting items are probably the [hex].wilhelm_symbolic property for each hexagram and the .comments property that tags alongside every text to further explain the context lost in translation / time.

The [hex].wilhelm_above, and [hex].wilhelm_below objects and their .chinese, .symbolic, and .alchemical properties would also be nice additions for more context on the trigrams.

PS: Thanks for making this little project! I use it in a greeting script I made to spice up my mornings, and I've used it for about 2 years or so now.

@jtrv
Copy link
Author

jtrv commented Feb 16, 2023

So far I used the data above to update the hexagrams.json file like so: https://github.com/JacobTravers/i-ching/blob/new-data/src/hexagrams.json

I also made a second branch using number keys instead of arrays like the data-set did: https://github.com/JacobTravers/i-ching/blob/new-data-new-shape/src/hexagrams.json

I thought it was a good idea and might make accessing those values nicer, although I'm new to rust and haven't looked at the rest of the code much, so I'm not sure if it is actually worth doing.

@Velfi
Copy link
Owner

Velfi commented Jun 13, 2023

I'm quite busy these days and don't spend much time on this specific project. However, that file you linked does look nice.

Next time I'm hacking on this project, I'll try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants