From f687fc79684a6ca86223ad04dce597639e094530 Mon Sep 17 00:00:00 2001 From: Alejandro Santiago Date: Wed, 12 Jun 2024 15:47:52 +0100 Subject: [PATCH] feat!: update VGA to Dart 3.4 (#101) * feat!: update VGA to Dart 3.4 * feat: add no_wildcard_variable_uses * docs: update ordering * chore: remove unnecessary_library_name * docs: update reasons * docs: update CHANGELOG * docs: undo spacing --- CHANGELOG.md | 12 +- README.md | 5 +- lib/analysis_options.6.0.0.yaml | 211 +++++++++++++++++++++++ lib/analysis_options.yaml | 2 +- pubspec.yaml | 2 +- tool/linter_rules/exclusion_reasons.json | 5 +- 6 files changed, 223 insertions(+), 14 deletions(-) create mode 100644 lib/analysis_options.6.0.0.yaml diff --git a/CHANGELOG.md b/CHANGELOG.md index a221642..f459d5c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,11 @@ +# 6.0.0 (Unreleased) + +- feat!: upgrade to support Dart `^3.4.0` +- feat: additional lint rules: + - [missing_code_block_language_in_doc_comment](https://dart.dev/tools/linter-rules/missing_code_block_language_in_doc_comment) + - [no_self_assignments](https://dart.dev/tools/linter-rules/no_self_assignments) + - [no_wildcard_variable_uses](https://dart.dev/tools/linter-rules/no_wildcard_variable_uses) + # 5.1.0 - fix: remove deprecated `iterable_contains_unrelated_type` lint @@ -12,19 +20,15 @@ # 5.0.0 - feat!: upgrade to support Dart `^3.0.0` - - feat: added analysis warning as error: - [record_literal_one_positional_no_trailing_comma](https://dart.dev/tools/diagnostic-messages#record_literal_one_positional_no_trailing_comma) - - feat: additional lint rules: - [implicit_reopen](https://dart.dev/tools/linter-rules#implicit_reopen) - [unnecessary_breaks](https://dart.dev/tools/linter-rules#unnecessary_breaks) - [invalid_case_patterns](https://github.com/dart-lang/linter/issues/4044) - - refactor: remove deprecated lint rules: - [prefer_equal_for_default_values](https://dart-lang.github.io/linter/lints/prefer_equal_for_default_values.html) - [enable_null_safety](https://dart-lang.github.io/linter/lints/enable_null_safety.html) - - refactor: remove malfunctioning rules: - [`use_decorated_box`](https://github.com/VeryGoodOpenSource/very_good_analysis/issues/65) diff --git a/README.md b/README.md index 587b763..a85ac0e 100644 --- a/README.md +++ b/README.md @@ -107,10 +107,7 @@ Below is a list of rules that are not enabled by default together with the reaso | [`discarded_futures`](https://dart.dev/tools/linter-rules/discarded_futures) | [Has unresolved false positives](https://github.com/VeryGoodOpenSource/very_good_analysis/issues/74#issuecomment-1668425410) | | [`do_not_use_environment`](https://dart.dev/tools/linter-rules/do_not_use_environment) | Not specified | | [`matching_super_parameters`](https://dart.dev/tools/linter-rules/matching_super_parameters) | Not specified | -| [`missing_code_block_language_in_doc_comment`](https://dart.dev/tools/linter-rules/missing_code_block_language_in_doc_comment) | Not specified | | [`no_literal_bool_comparisons`](https://dart.dev/tools/linter-rules/no_literal_bool_comparisons) | Not specified | -| [`no_self_assignments`](https://dart.dev/tools/linter-rules/no_self_assignments) | Not specified | -| [`no_wildcard_variable_uses`](https://dart.dev/tools/linter-rules/no_wildcard_variable_uses) | Not specified | | [`prefer_double_quotes`](https://dart.dev/tools/linter-rules/prefer_double_quotes) | Incompatible with [prefer_single_quotes](https://dart.dev/tools/linter-rules/prefer_single_quotes) | | [`prefer_expression_function_bodies`](https://dart.dev/tools/linter-rules/prefer_expression_function_bodies) | Not specified | | [`prefer_final_parameters`](https://dart.dev/tools/linter-rules/prefer_final_parameters) | Not specified | @@ -119,7 +116,7 @@ Below is a list of rules that are not enabled by default together with the reaso | [`prefer_relative_imports`](https://dart.dev/tools/linter-rules/prefer_relative_imports) | Incompatible with [always_use_package_imports](https://dart.dev/tools/linter-rules/always_use_package_imports) | | [`type_literal_in_constant_pattern`](https://dart.dev/tools/linter-rules/type_literal_in_constant_pattern) | Not specified | | [`unnecessary_final`](https://dart.dev/tools/linter-rules/unnecessary_final) | Not specified | -| [`unnecessary_library_name`](https://dart.dev/tools/linter-rules/unnecessary_library_name) | Not specified | +| [`unnecessary_library_name`](https://dart.dev/tools/linter-rules/unnecessary_library_name) | [Pending recommendation](https://github.com/dart-lang/lints/issues/181) | | [`unnecessary_null_aware_operator_on_extension_on_nullable`](https://dart.dev/tools/linter-rules/unnecessary_null_aware_operator_on_extension_on_nullable) | Not specified | | [`unreachable_from_main`](https://dart.dev/tools/linter-rules/unreachable_from_main) | Not specified | | [`unsafe_html`](https://dart.dev/tools/linter-rules/unsafe_html) | Not specified | diff --git a/lib/analysis_options.6.0.0.yaml b/lib/analysis_options.6.0.0.yaml new file mode 100644 index 0000000..9e46cab --- /dev/null +++ b/lib/analysis_options.6.0.0.yaml @@ -0,0 +1,211 @@ +analyzer: + language: + strict-casts: true + strict-inference: true + strict-raw-types: true + + errors: + close_sinks: ignore + missing_required_param: error + missing_return: error + record_literal_one_positional_no_trailing_comma: error + collection_methods_unrelated_type: warning + unrelated_type_equality_checks: warning + + exclude: + - test/.test_coverage.dart + - lib/generated_plugin_registrant.dart + +linter: + rules: + - always_declare_return_types + - always_put_required_named_parameters_first + - always_use_package_imports + - annotate_overrides + - avoid_bool_literals_in_conditional_expressions + - avoid_catching_errors + - avoid_double_and_int_checks + - avoid_dynamic_calls + - avoid_empty_else + - avoid_equals_and_hash_code_on_mutable_classes + - avoid_escaping_inner_quotes + - avoid_field_initializers_in_const_classes + - avoid_final_parameters + - avoid_function_literals_in_foreach_calls + - avoid_init_to_null + - avoid_js_rounded_ints + - avoid_multiple_declarations_per_line + - avoid_null_checks_in_equality_operators + - avoid_positional_boolean_parameters + - avoid_print + - avoid_private_typedef_functions + - avoid_redundant_argument_values + - avoid_relative_lib_imports + - avoid_renaming_method_parameters + - avoid_return_types_on_setters + - avoid_returning_null_for_void + - avoid_returning_this + - avoid_setters_without_getters + - avoid_shadowing_type_parameters + - avoid_single_cascade_in_expression_statements + - avoid_slow_async_io + - avoid_type_to_string + - avoid_types_as_parameter_names + - avoid_unnecessary_containers + - avoid_unused_constructor_parameters + - avoid_void_async + - avoid_web_libraries_in_flutter + - await_only_futures + - camel_case_extensions + - camel_case_types + - cancel_subscriptions + - cascade_invocations + - cast_nullable_to_non_nullable + - collection_methods_unrelated_type + - combinators_ordering + - comment_references + - conditional_uri_does_not_exist + - constant_identifier_names + - control_flow_in_finally + - curly_braces_in_flow_control_structures + - dangling_library_doc_comments + - depend_on_referenced_packages + - deprecated_consistency + - directives_ordering + - empty_catches + - empty_constructor_bodies + - empty_statements + - eol_at_end_of_file + - exhaustive_cases + - file_names + - flutter_style_todos + - hash_and_equals + - implicit_call_tearoffs + - implementation_imports + - implicit_reopen + - invalid_case_patterns + - join_return_with_assignment + - leading_newlines_in_multiline_strings + - library_annotations + - library_names + - library_prefixes + - library_private_types_in_public_api + - lines_longer_than_80_chars + - literal_only_boolean_expressions + - missing_code_block_language_in_doc_comment + - missing_whitespace_between_adjacent_strings + - no_adjacent_strings_in_list + - no_default_cases + - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers + - no_logic_in_create_state + - no_runtimeType_toString + - no_self_assignments + - no_wildcard_variable_uses + - non_constant_identifier_names + - noop_primitive_operations + - null_check_on_nullable_type_parameter + - null_closures + - omit_local_variable_types + - one_member_abstracts + - only_throw_errors + - overridden_fields + - package_api_docs + - package_names + - package_prefixed_library_names + - parameter_assignments + - prefer_adjacent_string_concatenation + - prefer_asserts_in_initializer_lists + - prefer_asserts_with_message + - prefer_collection_literals + - prefer_conditional_assignment + - prefer_const_constructors + - prefer_const_constructors_in_immutables + - prefer_const_declarations + - prefer_const_literals_to_create_immutables + - prefer_constructors_over_static_methods + - prefer_contains + - prefer_final_fields + - prefer_final_in_for_each + - prefer_final_locals + - prefer_for_elements_to_map_fromIterable + - prefer_function_declarations_over_variables + - prefer_generic_function_type_aliases + - prefer_if_elements_to_conditional_expressions + - prefer_if_null_operators + - prefer_initializing_formals + - prefer_inlined_adds + - prefer_int_literals + - prefer_interpolation_to_compose_strings + - prefer_is_empty + - prefer_is_not_empty + - prefer_is_not_operator + - prefer_iterable_whereType + - prefer_null_aware_method_calls + - prefer_null_aware_operators + - prefer_single_quotes + - prefer_spread_collections + - prefer_typing_uninitialized_variables + - prefer_void_to_null + - provide_deprecation_message + - public_member_api_docs + - recursive_getters + - require_trailing_commas + - secure_pubspec_urls + - sized_box_for_whitespace + - sized_box_shrink_expand + - slash_for_doc_comments + - sort_child_properties_last + - sort_constructors_first + - sort_pub_dependencies + - sort_unnamed_constructors_first + - test_types_in_equals + - throw_in_finally + - tighten_type_of_initializing_formals + - type_annotate_public_apis + - type_init_formals + - unawaited_futures + - unnecessary_await_in_return + - unnecessary_breaks + - unnecessary_brace_in_string_interps + - unnecessary_const + - unnecessary_constructor_name + - unnecessary_getters_setters + - unnecessary_lambdas + - unnecessary_late + - unnecessary_library_directive + - unnecessary_new + - unnecessary_null_aware_assignments + - unnecessary_null_checks + - unnecessary_null_in_if_null_operators + - unnecessary_nullable_for_final_variable_declarations + - unnecessary_overrides + - unnecessary_parenthesis + - unnecessary_raw_strings + - unnecessary_statements + - unnecessary_string_escapes + - unnecessary_string_interpolations + - unnecessary_this + - unnecessary_to_list_in_spreads + - unrelated_type_equality_checks + - use_build_context_synchronously + - use_colored_box + - use_enums + - use_full_hex_values_for_flutter_colors + - use_function_type_syntax_for_parameters + - use_if_null_to_convert_nulls_to_bools + - use_is_even_rather_than_modulo + - use_key_in_widget_constructors + - use_late_for_private_fields_and_variables + - use_named_constants + - use_raw_strings + - use_rethrow_when_possible + - use_setters_to_change_properties + - use_string_buffers + - use_string_in_part_of_directives + - use_super_parameters + - use_test_throws_matchers + - use_to_and_as_if_applicable + - valid_regexps + - void_checks diff --git a/lib/analysis_options.yaml b/lib/analysis_options.yaml index 799268d..bb72091 100644 --- a/lib/analysis_options.yaml +++ b/lib/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.5.1.0.yaml +include: package:very_good_analysis/analysis_options.6.0.0.yaml diff --git a/pubspec.yaml b/pubspec.yaml index d37f3fd..42b9640 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -8,4 +8,4 @@ documentation: https://github.com/VeryGoodOpenSource/very_good_analysis topics: [lints, analyzer, analysis] environment: - sdk: ">=3.0.0 <4.0.0" + sdk: ^3.4.0 diff --git a/tool/linter_rules/exclusion_reasons.json b/tool/linter_rules/exclusion_reasons.json index ebddf49..56a7849 100644 --- a/tool/linter_rules/exclusion_reasons.json +++ b/tool/linter_rules/exclusion_reasons.json @@ -13,10 +13,7 @@ "discarded_futures": "[Has unresolved false positives](https://github.com/VeryGoodOpenSource/very_good_analysis/issues/74#issuecomment-1668425410)", "do_not_use_environment": "Not specified", "matching_super_parameters": "Not specified", - "missing_code_block_language_in_doc_comment": "Not specified", "no_literal_bool_comparisons": "Not specified", - "no_self_assignments": "Not specified", - "no_wildcard_variable_uses": "Not specified", "prefer_double_quotes": "Incompatible with [prefer_single_quotes](https://dart.dev/tools/linter-rules/prefer_single_quotes)", "prefer_expression_function_bodies": "Not specified", "prefer_final_parameters": "Not specified", @@ -25,7 +22,7 @@ "prefer_relative_imports": "Incompatible with [always_use_package_imports](https://dart.dev/tools/linter-rules/always_use_package_imports)", "type_literal_in_constant_pattern": "Not specified", "unnecessary_final": "Not specified", - "unnecessary_library_name": "Not specified", + "unnecessary_library_name": "[Pending recommendation](https://github.com/dart-lang/lints/issues/181)", "unnecessary_null_aware_operator_on_extension_on_nullable": "Not specified", "unreachable_from_main": "Not specified", "unsafe_html": "Not specified",