Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Time Setup Window #166

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

First Time Setup Window #166

wants to merge 18 commits into from

Conversation

zeptofine
Copy link
Collaborator

@zeptofine zeptofine commented Nov 6, 2024

A First-time setup window. #165

This lets users go through settings upon first opening up the software, showing required options that the software can't run without, and optional stuff they may not know exist, like file associations and proxies. Some pages change depending on which OS you're on, most notably the file association page.

Once it's first shown, it never appears again.

@zeptofine zeptofine linked an issue Nov 6, 2024 that may be closed by this pull request
@zeptofine
Copy link
Collaborator Author

Rebased the branch to main

@zeptofine zeptofine requested a review from Victor-IX November 12, 2024 15:37
@Victor-IX
Copy link
Owner

So cool to have this!

Do you think it would be possible to add a default path for the launcher library, for example, the User Documents folder on Windows?
By default, it creates the library in the .exe location, and I don't think this is ideal. I saw some people leaving the default path and having the entire library folders on the desktop or in the downloads folder😅.

Also, do you think it would be possible to move the .exe file where the library is and have the option to create a shortcut on the desktop? I don't know if the Blender Launcher can be registered by Windows as an installed program to be available in the Windows search. This could be nice in case someone doesn't want to create a shortcut but still wants quick access to the program in the Windows apps menu.

Unrelated, but do you think it would be a good idea to force trigger the initial setup step for all older versions when they update, so users can update their settings as needed? (Only for the next update, not all the time.)
I'm thinking about this because a lot of people still have the old default settings, especially with the tray icon, and this creates a lot of confusion for multiple users.

@zeptofine
Copy link
Collaborator Author

Do you think it would be possible to add a default path for the launcher library, for example, the User Documents folder on Windows?

Yes, this is possible

Also, do you think it would be possible to move the .exe file where the library is

Yup, luckily we can copy and delete sys.executable on frozen builds

and have the option to create a shortcut on the desktop? I don't know if the Blender Launcher can be registered by Windows as an installed program to be available in the Windows search.

Well, the way applications typically add themselves to the Windows Start Menu is by placing shortcuts in a specific user folder. I think that's the default location for shortcuts, correct me if I'm wrong. We could go the typical Add to Start Menu and Add to Desktop checkboxes route

Unrelated, but do you think it would be a good idea to force trigger the initial setup step for all older versions when they update, so users can update their settings as needed? (Only for the next update, not all the time.)

Yes, this is the default. It only shows up if the first_time_seen flag has not been enabled, which should never be enabled on older versions

Sorry that development has been frozen here, it's been a busy couple weeks irl for me 😅

@Victor-IX
Copy link
Owner

I have a silent crash when clicking on next on the Set repo visibility step

@Victor-IX
Copy link
Owner

Sorry for taking so much time reviewing that. I finally have some time during my winter vacation!

I have this error when it's trying to move the .exe to the lib location

Finished page Welcome to Blender Launcher v2.3.0-rc.2!

ERR OCCURRED DURING PAGE "First, choose where Blender builds will be stored"!
Traceback (most recent call last):
  File "windows\onboarding_window.py", line 50, in run
  File "widgets\onboarding_setup\wizard_pages.py", line 144, in evaluate
  File "pathlib.py", line 1206, in unlink
PermissionError: [WinError 5] Access is denied: 'H:\\Projects\\Blender-Launcher-V2\\dist\\release\\Blender Launcher.exe'

And this one when it try to create the windows shortcut

Finished page Welcome to Blender Launcher v2.3.0-rc.2!
Finished page First, choose where Blender builds will be stored
Finished page Choose which repositories you want enabled

ERR OCCURRED DURING PAGE "Shortcuts / Launching Blendfiles (.blend, .blend1)"!
Traceback (most recent call last):
  File "win32com\client\dynamic.py", line 86, in _GetGoodDispatch
pywintypes.com_error: (-2147221008, 'CoInitialize has not been called.', None, None)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "windows\onboarding_window.py", line 50, in run
  File "widgets\onboarding_setup\wizard_pages.py", line 252, in evaluate
  File "modules\shortcut.py", line 213, in generate_program_shortcut
  File "win32com\client\__init__.py", line 117, in Dispatch
  File "win32com\client\dynamic.py", line 106, in _GetGoodDispatchAndUserName
  File "win32com\client\dynamic.py", line 88, in _GetGoodDispatch
pywintypes.com_error: (-2147221008, 'CoInitialize has not been called.', None, None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

First-Time Setup Window
2 participants