Unauthenticated requests to GitHub can be ratelimited

[zeptofine]

Describe the bug
Requests that BLV2 make to GitHub for the latest build and the launcher api are ratelimited after an amount of time and affects other programs that request to GitHub without authentication.

For the log file, I added a print statement before the error point to find exactly what was being returned.

To Reproduce
Run scraping enough times to hit the GH ratelimit (I just did apparently)

System (please complete the following information):

• Operation system: Archlinux
• Blender Launcher version: 6fe52a3 main
• Log file: Blender Launcher.log

Additional context
A possible solution would be to let the user add their own GitHub token so we can authenticate our requests properly. We will need to store them securely, perhaps with https://pypi.org/project/keyring/

[Victor-IX]

I knew about this but didn't think we would reach the limit of 5000 per hour.
Do you know if the limit is shared between all Blender Launcher requests, or is it per user?

A possible solution would be to let the user add their own GitHub token so we can authenticate our requests properly. We will need to store them securely, perhaps with https://pypi.org/project/keyring/

This would be a good solution. We could also implement a rate limiter inside the Blender Launcher to only make API requests once every 24 hours.

[zeptofine]

I knew about this but didn't think we would reach the limit of 5000 per hour. Do you know if the limit is shared between all Blender Launcher requests, or is it per user?

I think it's moreso per IP than per user
As you can see in the log, it referenced my IP along with the error message (I hid it). That leads me to believe that it limits based on your IP and not a specific machine, so those who share an IP with multiple people, eg. businesses and educational organizations, may be requesting from the GitHub API a ton.
Since I am at a college with a big Engineering department, there may be some other students who use the GitHub API frequently

[Victor-IX]

so those who share an IP with multiple people, eg. businesses and educational organizations, may be requesting from the GitHub API a ton.
Since I am at a college with a big Engineering department, there may be some other students who use the GitHub API frequently

Oh yeah, that makes sense why you hit the limit. In this case, the token is the way to go!