Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of implicit broadcasting for read procs taking indices #23

Open
Vindaar opened this issue Jul 25, 2019 · 0 comments
Open

Get rid of implicit broadcasting for read procs taking indices #23

Vindaar opened this issue Jul 25, 2019 · 0 comments

Comments

@Vindaar
Copy link
Owner

Vindaar commented Jul 25, 2019

Currently the procs to read a subset from a dataset instead of the whole will broadcast the seq[int] indices given to all dimensions of an N dimensional dataset. This was introduced as a convenience tool.

However, looking back at this after a while I realize this is just confusing and not intuitive.

Instead we should either use as a default an interpretation of the indices of the flattened data or introduce a better way to read indices for multidimensional datasets that allows for broadcasting via some symbol. Some inspiration could be taken from arraymancer's accessor [] macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant