Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove built-in tax providers #43

Open
j-mok opened this issue Mar 13, 2023 · 0 comments
Open

Can't remove built-in tax providers #43

j-mok opened this issue Mar 13, 2023 · 0 comments

Comments

@j-mok
Copy link

j-mok commented Mar 13, 2023

In VC v2 we could replace all existing tax providers by implementing VirtoCommerce.Domain.Tax.Services.ITaxService.GetAllTaxProviders(). With version 3 this is no longer possible. The new ITaxProviderRegistrar provides only a method to register a new tax provider, there is no way to override or unregister exiting ones. The underlying AbstractTypeFactory<TaxProvider> in RegisterTaxProvider's stock implementation does not make thing much easier - it can't have types unregistered either, just overridden, which is some sort of a workaround for now. Still we don't want to rely on implementation details and make brittle code, we'd very much rather see a proper UnregisterAllTaxProviders() or something along the lines in ITaxProviderRegistrar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant