You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In VC v2 we could replace all existing tax providers by implementing VirtoCommerce.Domain.Tax.Services.ITaxService.GetAllTaxProviders(). With version 3 this is no longer possible. The new ITaxProviderRegistrar provides only a method to register a new tax provider, there is no way to override or unregister exiting ones. The underlying AbstractTypeFactory<TaxProvider> in RegisterTaxProvider's stock implementation does not make thing much easier - it can't have types unregistered either, just overridden, which is some sort of a workaround for now. Still we don't want to rely on implementation details and make brittle code, we'd very much rather see a proper UnregisterAllTaxProviders() or something along the lines in ITaxProviderRegistrar.
The text was updated successfully, but these errors were encountered:
In VC v2 we could replace all existing tax providers by implementing
VirtoCommerce.Domain.Tax.Services.ITaxService.GetAllTaxProviders()
. With version 3 this is no longer possible. The newITaxProviderRegistrar
provides only a method to register a new tax provider, there is no way to override or unregister exiting ones. The underlyingAbstractTypeFactory<TaxProvider>
inRegisterTaxProvider
's stock implementation does not make thing much easier - it can't have types unregistered either, just overridden, which is some sort of a workaround for now. Still we don't want to rely on implementation details and make brittle code, we'd very much rather see a properUnregisterAllTaxProviders()
or something along the lines inITaxProviderRegistrar
.The text was updated successfully, but these errors were encountered: