feat(core): use-formts setup #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pidkopajo
force-pushed
the
feat/use-formts-draft
branch
from
ef83d49 to
1a53507
Compare
mixvar
approved these changes
Sep 30, 2020
Comment on lines
10
to
24
| it("for one-element schema", () => { | ||
| const schema = createFormSchema(fields => ({ | ||
| stringField: fields.string(), | ||
| })); | ||
|
|
||
| expect(createInitialState(schema)).toEqual({ stringField: "" }); | ||
| }); | ||
|
|
||
| it("for one-element schema", () => { | ||
| const schema = createFormSchema(fields => ({ | ||
| stringField: fields.string(), | ||
| })); | ||
|
|
||
| expect(createInitialState(schema)).toEqual({ stringField: "" }); | ||
| }); |
| }, | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
maybe another test case test case for sth like
const schema = createFormSchema(fields => ({
arr: fields.array(fields.object({ foo: fields.string(), bar: fields.string() }))
}));
const init = { arr: [{ foo: "foo" }]}
const expectedResult = { arr: [{ foo: "foo", bar: "" }]}
| assert<IsExact<typeof root, ("a" | "b" | "c")[]>>(true); | ||
|
|
||
| const first = get(Schema.theArrayChoice.nth(0)); | ||
| assert<IsExact<typeof first, "a" | "b" | "c">>(true); |
There was a problem hiding this comment.
shouldn't it be "a" | "b" | "c" | undefiend ?
Comment on lines
+30
to
+36
| export const isArrayDesc = <Value>( | ||
| x: _DescriptorApprox_<Value> | ||
| ): x is _ArrayDescriptorApprox_<Value> => "nth" in x && "root" in x; | ||
|
|
||
| export const isObjectDesc = <Value>( | ||
| x: _DescriptorApprox_<Value> | ||
| ): x is _ObjectDescriptorApprox_<Value> => "root" in x && !("nth" in x); |
| }); | ||
| }); | ||
|
|
||
| describe("set", () => { |
There was a problem hiding this comment.
the set implementation is really nice - it preserves Structural sharing - meaning that we don't just deep copy the input, but only copy the stuff that was updated.
I think we could reflect that in tests, something like
const original = {
left: { a: { id: 1 }, b: { id: 2 } },
right: { a: { id: 3 }, b: { id: 4 } },
};
const updated = set(obj, "right.b.id", 10)
expect(original).not.toBe(updated)
expect(original.right).not.toBe(updated.right)
expect(original.right.b).not.toBe(updated.right.b)
expect(original.right.a).toBe(updated.right.a)
expect(original.left).toBe(updated.left)|
|
||
| // loose typing for helping with internal impl, as working with generic target types is impossible | ||
|
|
||
| export type _FormSchemaApprox_<Values extends object> = { |
There was a problem hiding this comment.
shouldn't that be used in create-form-schema.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a basic setup for
use-formtshook.Currently, it only constructs a scheme-shaped tree of initial values and exports simple getter and setter.
Hook is not yet connected to react.