feat(core): use formts validation and submit handling #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 11, 2020 00:46
- store errors state as dictionary - expose getter/setter for field errors - expose list of all form errors - expose computed isValid property for fields and form
call validator when: - field value is set - field is touched - field validate method is called - form validate method is called
mixvar
commented
Oct 18, 2020
|
|
||
| dispatch({ type: "setIsValidating", payload: { isValidating: true } }); | ||
| return options.validator | ||
| .validate(topLevelDescriptors, getField) |
There was a problem hiding this comment.
this assumes validator runs validation recursively for nested fields when receiving root object or root array description. Looks like we don't have it implemented yet on the validator side - we can add this later after flattening the schema shape (should make it easier to implement)
pidkopajo
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors,isValidatingandisSubmittingto stateget/set error,validate(),get isValid, and running validation on change and blurget isSubmitting,get isValidating,get errors,get isValid,validate(),reset(),getSubmitHandler()notes:
isValidatingleft for latercloses #5
touches #7