feat: handle change method #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 12, 2021 22:14
- simplifu decoder return type - allow nulls in instanceOf decoder - expose constructor from isntanceOf decoder
pidkopajo
approved these changes
Jan 17, 2021
| return Number.isFinite(value) | ||
| ? { ok: true, value } | ||
| : { ok: false, value }; | ||
| return Number.isFinite(value) ? { ok: true, value } : { ok: false }; |
There was a problem hiding this comment.
minor, imho it's worth mentioning in docs, what values/types are accepted, as the area wider than finite numbers only
same for the rest of the decoders
There was a problem hiding this comment.
each decoder has jsdoc attached to it, check them out :)
for number there is:
/**
* Define field of type `number | ""` (empty string is needed to represent state of empty number inputs)
* Does not accept infinite numbers: `Infinity`, `-Infinity`, `NaN`.
* Default initial value will be `""`.
*
* @example
* ```
* const Schema = createForm.schema(fields => ({
* x: fields.number() // x: number | ""
* }));
* ```
*/
pidkopajo
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldHandle.handleChangewhich attempts to extract value out of change events for convenience.instanceOfdecoder in favour ofdatedecodercloses #49