Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version of Scala to the output of scala-cli --version #1250

Closed
romanowski opened this issue Aug 15, 2022 · 2 comments · Fixed by #1262
Closed

Add version of Scala to the output of scala-cli --version #1250

romanowski opened this issue Aug 15, 2022 · 2 comments · Fixed by #1262
Assignees
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.

Comments

@romanowski
Copy link
Member

Is your feature request related to a problem? Please describe.

Getting the version of the launcher is important mainly for advanced users; beginners would expect to see a version of Scala used.

See more in the @julienrf comment: scala/improvement-proposals#46 (comment)

Describe the solution you'd like
When running scala-cli --version the default version of Scala is printed as well as the version of the launcher. With a provided argument (e.g. scala-cli --version .), the version of Scala as configured in the argument should be provided.

Describe alternatives you've considered
A dedicated command/argument to print Scala version.

@romanowski romanowski added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Aug 15, 2022
@bjornregnell
Copy link
Contributor

bjornregnell commented Aug 15, 2022

Good!
And it would be helpful and good UX / DX if all these worked:

scala-cli -v
scala-cli --version
scala-cli -version
scala-cli version

(but not as critical as with all variants of scala-cli help, as the help command hopefully explains how to use the version command...)

@lwronski
Copy link
Contributor

If we change behaviours of command scala-cli --version, it needs to be updated logic in update command, because there we run scala-cli --version command to find out which version of Scala Cli is already installed.

@lwronski lwronski self-assigned this Aug 17, 2022
@lwronski lwronski linked a pull request Aug 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants