Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generate-windows-launcher job fails intermittently on cs download timeout #2930

Closed
Gedochao opened this issue May 23, 2024 · 0 comments · Fixed by #3349
Closed

The generate-windows-launcher job fails intermittently on cs download timeout #2930

Gedochao opened this issue May 23, 2024 · 0 comments · Fixed by #3349
Labels
bug Something isn't working CI Issues tied with CI/CD workflows. internal Internal or build-related changes

Comments

@Gedochao
Copy link
Contributor

Version(s)
ebafbb8

Describe the bug
The generate-windows-launcher job got extremely flaky, seemingly failing very often on the cs download.
We should investigate and try to fix it, as it otherwise forces us to restart jobs to no end.

Example failing build:

Example output:

download error: Caught java.net.ConnectException (Connection timed out: connect) while downloading https://download.libsodium.org/libsodium/releases/libsodium-1.0.18-stable-msvc.zip
1 targets failed
cli[3.3.3].base-image.staticLibDir os.SubprocessException: Result of C:\Users\runneradmin\AppData\Local\Coursier\cache\arc\https\github.com\coursier\coursier\releases\download\v2.1.10\cs-x86_64-pc-win32.zip\cs-x86_64-pc-win32.exe�: 1

    os.proc.call(ProcessOps.scala:95)
    millbuild.project.settings$CliLaunchers$CliNativeImage.copyLibsodiumStaticTo(settings.sc:239)
    millbuild.project.settings$CliLaunchers$CliNativeImage.$anonfun$staticLibDir$2(settings.sc:280)
    mill.define.Task$TraverseCtx.evaluate(Task.scala:71)

To Reproduce
Just run any CI job on main, the generate-windows-launcher job will fail ~4 times out of 5.

Expected behaviour
The generate-windows-launcher job should be passing consistently.

Potential solutions
We could try increasing the timeout or retrying the download.

@Gedochao Gedochao added bug Something isn't working internal Internal or build-related changes CI Issues tied with CI/CD workflows. labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Issues tied with CI/CD workflows. internal Internal or build-related changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant