Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent versions of mill break builds. #174

Closed
okennedy opened this issue Apr 2, 2022 · 6 comments
Closed

Recent versions of mill break builds. #174

okennedy opened this issue Apr 2, 2022 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@okennedy
Copy link
Contributor

okennedy commented Apr 2, 2022

Describe the bug
Compiling vizier with a recent mill fails

To Reproduce
mill vizier.compile

Expected behavior
everything should compile

Screenshots

[93/124] vizier.ui.fastOpt 
Found multiple public modules but module support is disabled: [main, out]
  exported to JavaScript with @JSExport
Linker: Compute reachability: 690054 us
Linker: 743346 us
1 targets failed
vizier.ui.fastOpt There were linking errors

This appears to be related to com-lihaoyi/mill#1684

Environment (please complete the following information):

mill --version
Mill Build Tool version 0.10.2
Java version: 1.8.0\_292, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
Default locale: en\_US, platform encoding: UTF-8
OS name: "Mac OS X", version: 10.16, arch: x86\_64
@okennedy okennedy added the bug Something isn't working label Apr 2, 2022
@okennedy okennedy added this to the Version 2.0 milestone Apr 2, 2022
@okennedy
Copy link
Contributor Author

okennedy commented Apr 2, 2022

Report courtesy of @lordpretzel

@mrb24
Copy link
Contributor

mrb24 commented Apr 14, 2022

Mill 0.10.1 is the mill version that breaks. Version 0.10.0 works.

@lolgab
Copy link

lolgab commented Apr 27, 2022

The following PR should fix the problem:
com-lihaoyi/mill#1851

@okennedy
Copy link
Contributor Author

Thanks @lolgab !

@lolgab
Copy link

lolgab commented May 3, 2022

Mill 0.10.3-36-e038bb contains the fix. Can you try to see if it solves your problem?

@mrb24
Copy link
Contributor

mrb24 commented May 3, 2022

Reference in new issue

Indeed, Mill 0.10.3-36-e038bb does fix our problem. Thanks!

@okennedy okennedy closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants