From ea3efa640f3a1dbf5daa313bf9b3d21706884888 Mon Sep 17 00:00:00 2001 From: feifeiji89 <163567487+feifeiji89@users.noreply.github.com> Date: Tue, 15 Oct 2024 10:30:39 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Andrew Paseltiner --- AGGREGATE.md | 2 +- index.bs | 2 +- ts/src/constants.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/AGGREGATE.md b/AGGREGATE.md index 7748412f0c..f75920a819 100644 --- a/AGGREGATE.md +++ b/AGGREGATE.md @@ -578,7 +578,7 @@ maximum contribution for each budget name for this source. [Trigger registrations](#attribution-trigger-registration) will accept an optional field `named_budgets`, which will be used to select the -contribution budget name for the generated aggregatable report. +named budget for the generated aggregatable report. ```jsonc { diff --git a/index.bs b/index.bs index d9461766cb..6534963ae8 100644 --- a/index.bs +++ b/index.bs @@ -1206,8 +1206,8 @@ Possible values are:
  • "trigger-aggregate-attributions-per-source-destination-limit"
  • "trigger-aggregate-deduplicated"
  • "trigger-aggregate-excessive-reports" -
  • "trigger-aggregate-insufficient-named-budget"
  • "trigger-aggregate-insufficient-budget" +
  • "trigger-aggregate-insufficient-named-budget"
  • "trigger-aggregate-no-contributions"
  • "trigger-aggregate-report-window-passed"
  • "trigger-aggregate-storage-limit" diff --git a/ts/src/constants.ts b/ts/src/constants.ts index 7c0668d73e..e906dad64d 100644 --- a/ts/src/constants.ts +++ b/ts/src/constants.ts @@ -83,8 +83,8 @@ export const triggerAggregatableDebugTypes: Readonly<[string, ...string[]]> = [ 'trigger-aggregate-deduplicated', 'trigger-aggregate-excessive-reports', 'trigger-aggregate-no-contributions', - 'trigger-aggregate-insufficient-named-budget', 'trigger-aggregate-insufficient-budget', + 'trigger-aggregate-insufficient-named-budget', 'trigger-aggregate-storage-limit', 'trigger-aggregate-report-window-passed', 'trigger-event-attributions-per-source-destination-limit',