Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web-platform-tests for onfreeze, onresume and wasDiscarded #19

Open
fmeawad opened this issue May 22, 2018 · 10 comments
Open

Add web-platform-tests for onfreeze, onresume and wasDiscarded #19

fmeawad opened this issue May 22, 2018 · 10 comments

Comments

@fmeawad
Copy link

fmeawad commented May 22, 2018

Currently, webdriver does not allow us to freeze/resume a page. To add those tests, we need to add webdriver support first.

The plan is as follows:

  1. Expose the internal blink code you need to the DevTools protocol (Done)
  2. Write the extension spec, broadcast to other browser vendors and vouch for interop
  3. Write the ChromeDriver implementation (WIP CL)
  4. Write the testdriver API
  5. Add WPT tests.
@foolip
Copy link
Member

foolip commented May 31, 2018

Hey @fmeawad, I came here from Intent to Ship: Page Lifecycle - to enable system initiated Discarding & Freezing. @kereliuk tells me you've been working with him to define a WebDriver extension and testdriver.js implementation, do you have links to those ongoing efforts?

@foolip
Copy link
Member

foolip commented May 31, 2018

Typo: web-page-tests → web-platform-tests :)

@kereliuk
Copy link

Here is a link to a CL for LayoutTests and testdriver-vendor.

@fmeawad fmeawad changed the title Add web-page-tests for onfreeze, onresume and wasDiscarded Add web-platform-tests for onfreeze, onresume and wasDiscarded May 31, 2018
@fmeawad
Copy link
Author

fmeawad commented May 31, 2018

@foolip: I fixed the issue title.
I have 2 CLs in the works: The first CL that adds the wpt test, and adds support for it using chromeGPUBenchmarking, that would fail on wpt.fyi but would succeed as part of the chromium build tree.
The second CL adds support in ChromeDriver for it, so that we can eventually enable it on wpt.fyi as well once all the pieces are in place.

@foolip
Copy link
Member

foolip commented May 31, 2018

That's really cool! I suppose that the WebDriver extension bit in the spec would also be straightforward? With all those bits in place, this would be the first end-to-end addition of an automation API for a new feature, which is very exciting!

@spanicker
Copy link
Collaborator

This is blocked on: web-platform-tests/wpt#12380
Otherwise we have a patch ready to submit once that is in.

@foolip
Copy link
Member

foolip commented Sep 14, 2018

web-platform-tests/wpt#12380 has been landed now. It's not the default way that Chrome is run yet, @gsnedders is working on that, but your patch against it should be possible to submit.

@domenic
Copy link
Collaborator

domenic commented May 14, 2019

@spanicker @dtapuska is someone able to port the tests over? Maybe they already have and this issue can be closed?

@dtapuska
Copy link
Contributor

From the looks of it freeze.html on wpt.fyi is still not passing. It passes in Chrome's wpt test harness but not in wpt.fyi

@gsnedders is there something still to land?

@gsnedders
Copy link

web-platform-tests/wpt#16396 I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants