Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in section 3.1 #25

Closed
thw0rted opened this issue Nov 3, 2020 · 2 comments
Closed

Typo in section 3.1 #25

thw0rted opened this issue Nov 3, 2020 · 2 comments

Comments

@thw0rted
Copy link

thw0rted commented Nov 3, 2020

Just before the 3.2 header there's a numbered list. Number 4, sub-item 3, reads in full as "Change the cache match algorithm to take". I think this sentiment was moved up to sub-item 1?

@letitz
Copy link
Collaborator

letitz commented Nov 17, 2020

Partly, but I think some of the info is still missing. How exactly is the request network type populated? @mikewest for input on his original vision.

@letitz
Copy link
Collaborator

letitz commented Dec 10, 2020

Response from Mike:

The core of the idea was to take the address space of the request into account when determining whether or not to accept a cached entry. That is, we should not use a cached response generated from https://a on a public network when evaluating requests to https://a loaded from a private network. This doesn't feel like a huge issue, but it's relatively straightforward-seeming to extend the cache entry with an address space, and to take that into account in the matching algorithms.

@letitz letitz closed this as completed in 3e2d9de May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants