Replace TrustedURL with calling a default policy on navigation to javascript: URLs. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koto
force-pushed
the
jshook
branch
2 times, most recently
from
38fb44d to
9a4d801
Compare
nreid260
pushed a commit
to google/closure-library
that referenced
this pull request
Aug 21, 2019
… as they will soon be removed from the Trusted Types API - w3c/trusted-types#204. goog.createTrustedTypesPolicy will attempt to create a default policy allowing any value to be converted to TrustedURL. RELNOTES: Trusted Types integrations will allow any value to be a TrustedURL via defensively creating a 'default' policy (to prepare for TrustedURL deprecation) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=264626714
3 tasks
shicks
pushed a commit
to google/closure-library
that referenced
this pull request
Aug 30, 2019
*** Reason for rollback *** This breaks instances in report-only Trusted-Types enforcement, where non-TrustedURL types are passed to the sinks. w3c/trusted-types#209 *** Original change description *** Make Closure Trusted Types integration not require TrustedURL values, as they will soon be removed from the Trusted Types API - w3c/trusted-types#204. goog.createTrustedTypesPolicy will attempt to create a default policy allowing any value to be converted to TrustedURL. RELNOTES: Trusted Types integrations will allow any value to be a TrustedURL via defensively creating a 'default' policy (to prepare for TrustedURL deprecation) *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=265699886
mikewest
approved these changes
Sep 4, 2019
kjin
pushed a commit
to google/closure-library
that referenced
this pull request
Oct 16, 2019
Trusted Types are about to remove TrustedURL. See w3c/trusted-types#204. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=273756987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the burden from all authors to create types when interacting with common sinks that usually don't cause DOM XSS (unless for javascript: URLs).
This PR prevents
javascript:URLs from working by default, and allows programmatic opt-in to enable them one-by-onefor the few applications that need them.Related to #176.
Partially addresses #169.
Fixes #64.