Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all date/time h5 elements with properly-styled time elements. #1182

Closed
benlk opened this issue Mar 25, 2016 · 5 comments
Closed

Replace all date/time h5 elements with properly-styled time elements. #1182

benlk opened this issue Mar 25, 2016 · 5 comments

Comments

@benlk
Copy link
Collaborator

benlk commented Mar 25, 2016

Largo has a bunch of these:

<h5 class="top-date">April 2, 2015</h5>

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time

This is more of a semantic wish than anything else.

@benlk benlk added this to the Backlog milestone Mar 25, 2016
@rclations rclations modified the milestones: 0.6 - Performance & SEO, Backlog Jun 3, 2017
@mikeschinkel
Copy link

@benlk Has this been handled already in the develop branch? I can find no reference to "top-date" and published_date(), largo_comment() and largo_edited_date() are using <time> markup in the code I just cloned.

@benlk
Copy link
Collaborator Author

benlk commented Aug 19, 2017

The only place I'm seeing this any more is in partials/content-search, where we have <span class="date"><?php largo_time(); ?></span>. When largo_time() outputs a date, it's only outputting the string, not HTML: https://github.com/INN/largo/blob/develop/inc/post-tags.php#L59

@benlk benlk changed the title Replace all date/time h5 elements with properly-styles time elements. Replace all date/time h5 elements with properly-styled time elements. Aug 19, 2017
@mikeschinkel
Copy link

mikeschinkel commented Aug 19, 2017

@benlk @rclations #1469

@benlk
Copy link
Collaborator Author

benlk commented Aug 20, 2019

Resolved with #1469, but we have more h5 elements to remove. I'll create issues for those separately.

@benlk benlk closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants