Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related posts widget hide byline option doesn't work #1242

Closed
aschweigert opened this issue Jun 27, 2016 · 2 comments
Closed

related posts widget hide byline option doesn't work #1242

aschweigert opened this issue Jun 27, 2016 · 2 comments
Assignees
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Milestone

Comments

@aschweigert
Copy link

The language in the widget settings is incorrect (it says "Show date with each post") and is set to false by default. The option is actually called show_byline, which is correct, and what the option should actually do. However, even if the box is checked, it doesn't do anything to modify the markup that is actually output. So, we should fix the language (use "Show byline?" instead) and then make it actually, y'know, show the byline when checked. Default: do not show the byline.

@aschweigert aschweigert added type: bug priority: normal Must be completed before release of this version of plugin. labels Jun 27, 2016
@aschweigert aschweigert added this to the 0.5.5 - Story Elements milestone Jun 27, 2016
@aschweigert aschweigert added priority: high Either blocks work on a priority-normal task or a solution here informs other work. and removed priority: normal Must be completed before release of this version of plugin. labels Jun 27, 2016
@aschweigert
Copy link
Author

this should be a hotfix on master because it's presently broken (and ugly) and on chicago catalyst

@aschweigert
Copy link
Author

also, it appears the thumbnail location option doesn't do anything either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. type: bug
Projects
None yet
Development

No branches or pull requests

2 participants