Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further byline changes in develop #1259

Closed
4 tasks done
benlk opened this issue Jul 22, 2016 · 5 comments
Closed
4 tasks done

Further byline changes in develop #1259

benlk opened this issue Jul 22, 2016 · 5 comments
Assignees
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: in progress type: feature request
Milestone

Comments

@benlk
Copy link
Collaborator

benlk commented Jul 22, 2016

  • change 'Last modified' to 'Updated'
  • create method in the Largo byline class generic conditional function to check if a post has been updated, by diffing published and updated times
  • display normal largo_time published date if not is_single() or if it hasn't been updated
  • display updated date if it's been updated, even if not logged in

This extends #1126 somewhat

@benlk benlk added this to the 0.6 milestone Jul 22, 2016
@benlk benlk self-assigned this Jul 22, 2016
@aschweigert aschweigert added the priority: high Either blocks work on a priority-normal task or a solution here informs other work. label Aug 3, 2016
@aschweigert
Copy link

this is needed for rivard report

@benlk
Copy link
Collaborator Author

benlk commented Aug 3, 2016

In bylines in single posts, are we moving the date down to the main byline, or are we only displaying the date in the main byline if it's the Updated date?

The current Largo behavior is to hide the published date with CSS:

body.normal.single-post article.post > header .sep,
body.normal.page article.post > header .sep,
body.normal.single-post article.page > header .sep,
body.normal.page article.page > header .sep,
body.normal.single-post article.post > header .entry-date,
body.normal.page article.post > header .entry-date,
body.normal.single-post article.page > header .entry-date,
body.normal.page article.page > header .entry-date {
    display: none;
}

This is the published date's html:

<time class="entry-date updated dtstamp pubdate" datetime="2016-06-02T00:26:14+00:00"><span class="published">Published </span>June 2, 2016</time>

This is the updated date's html:

<span class="last-modified">Updated June 2, 2016 at 11:29 pm</span>

@aschweigert
Copy link

The current placement of the date doesn't really work and we should get rid of it and make this the new default. We should either include the published and/or updated date inline with the byline or we should put it on a new line below the byline (depending on how much space we have and how cramped it feels).

@aschweigert
Copy link

also, that css is insane, let's definitely not do that

@benlk
Copy link
Collaborator Author

benlk commented Aug 3, 2016

The craziness of those styles is due to #1264

  • remove date-hiding styles
  • remove current placement of date in the upper-right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Either blocks work on a priority-normal task or a solution here informs other work. status: in progress type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants