chore: remove 'no-cache' from API requests (#2538)

reown-com · Jul 15, 2024 · 45c68d3 · 45c68d3
1 parent 9d6d4b1
commit 45c68d3
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 13 deletions.
diff --git a/packages/core/src/controllers/BlockchainApiController.ts b/packages/core/src/controllers/BlockchainApiController.ts
@@ -129,7 +129,8 @@ export const BlockchainApiController = {
     projectId,
     cursor,
     onramp,
-    signal
+    signal,
+    cache
   }: BlockchainApiTransactionsRequest) {
     const queryParams = cursor ? { cursor } : {}
 
@@ -138,7 +139,8 @@ export const BlockchainApiController = {
         onramp ? `&onramp=${onramp}` : ''
       }`,
       params: queryParams,
-      signal
+      signal,
+      cache
     })
   },
 

diff --git a/packages/core/src/controllers/TransactionsController.ts b/packages/core/src/controllers/TransactionsController.ts
@@ -52,7 +52,9 @@ export const TransactionsController = {
         account: accountAddress,
         projectId,
         cursor: state.next,
-        onramp
+        onramp,
+        // Coinbase transaction history state updates require the latest data
+        cache: onramp === 'coinbase' ? 'no-cache' : undefined
       })
 
       const nonSpamTransactions = this.filterSpamTransactions(response.data)

diff --git a/packages/core/src/utils/FetchUtil.ts b/packages/core/src/utils/FetchUtil.ts
@@ -7,6 +7,7 @@ interface RequestArguments {
   path: string
   headers?: HeadersInit
   params?: Record<string, string | undefined>
+  cache?: RequestCache
   signal?: AbortSignal
 }
 
@@ -35,9 +36,9 @@ export class FetchUtil {
     this.baseUrl = baseUrl
   }
 
-  public async get<T>({ headers, signal, ...args }: RequestArguments) {
+  public async get<T>({ headers, signal, cache, ...args }: RequestArguments) {
     const url = this.createUrl(args)
-    const response = await fetchData(url, { method: 'GET', headers, signal, cache: 'no-cache' })
+    const response = await fetchData(url, { method: 'GET', headers, signal, cache })
 
     return response.json() as T
   }

diff --git a/packages/core/src/utils/TypeUtil.ts b/packages/core/src/utils/TypeUtil.ts
@@ -177,6 +177,7 @@ export interface BlockchainApiTransactionsRequest {
   cursor?: string
   onramp?: 'coinbase'
   signal?: AbortSignal
+  cache?: RequestCache
 }
 
 export interface BlockchainApiTransactionsResponse {

diff --git a/packages/core/tests/controllers/TransactionsController.test.ts b/packages/core/tests/controllers/TransactionsController.test.ts
@@ -45,7 +45,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     expect(TransactionsController.state.transactions).toEqual([])
@@ -80,7 +81,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     expect(TransactionsController.state.transactions).toEqual([])
@@ -105,7 +107,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     // Transaction should be replaced
@@ -140,7 +143,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     expect(TransactionsController.state.transactions).toEqual([])
@@ -165,7 +169,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     // Transaction should be replaced
@@ -200,7 +205,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     expect(TransactionsController.state.transactions).toEqual([])
@@ -225,7 +231,8 @@ describe('TransactionsController', () => {
       account: accountAddress,
       projectId,
       onramp: 'coinbase',
-      cursor: undefined
+      cursor: undefined,
+      cache: 'no-cache'
     })
 
     // Transaction should be replaced
@@ -261,7 +268,8 @@ describe('TransactionsController', () => {
       account: '0x123',
       projectId,
       cursor: undefined,
-      onramp: undefined
+      onramp: undefined,
+      cache: undefined
     })
     expect(TransactionsController.state.next).toBe('cursor')
   })