-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same test expected to result in different error messages #1841
Comments
I believe the spec interpreter only requires the expected error message to be a prefix of its actual error message, and in #1076 and #1089, the expected error messages at the time were edited to remove the indices (so that implementations wouldn't be required to produce a dynamically formatted error message). Some later tests have come in after this... |
Interesting - are some of these test quirks documented anywhere? There's a few I've picked up on (spectest globals initializing with the value 666 comes to mind) which are a bit hard to pick up on w/o asking around |
Unfortunately, not really. The closest you get to documentation for the .wast format is here. At least the signature of the spectest module is listed there as well, though not its values. I'll add that information to that doc. |
Done. |
Thanks! |
spec/test/core/data.wast
Line 298 in 1904486
spec/test/core/data.wast
Line 319 in 1904486
The above 2 tests seem to generate the same bytes, but two different error messages are expected from them. Not too sure which to interpret as the correct one.
The text was updated successfully, but these errors were encountered: