Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interpreter] OPAM package properly provides the .mli interfaces, but not the .ml files for modules such as Ast #593

Closed
msprotz opened this issue Oct 26, 2017 · 4 comments
Labels
interpreter issues that only affect the interpreter

Comments

@msprotz
Copy link
Contributor

msprotz commented Oct 26, 2017

Thanks,

Jonathan

@rossberg
Copy link
Member

@msprotz, pardon my ignorance, any hint what's at fault? I see that the Makefile's install target only explicitly lists mli files, but that has always been the case AFAICS. Should it include ml files as well?

@msprotz
Copy link
Contributor Author

msprotz commented Oct 27, 2017

No worries -- it's just good practice to include interface files so that one can do "jump to definition" from one's editor and see the definition of the type in the original source file. Since Ast.ml and others in syntax/ don't have an .mli, we could either:

  • add $(wildcard syntax/*.ml) and install the .ml files too, but I don't see many people installing .ml files into findlib directories, so it looks like it's not the right thing to do;
  • perhaps we could generate these .mlis via ocamlbuild's .inferred.mli rules and then copy them?

Anyhow, not a big deal, just a minor improvement :).

Thanks,

Jonathan

@ericprud
Copy link

@msprotz, @rossberg, has this been decided? Can this issue be closed?

@rossberg rossberg changed the title The OPAM package properly provides the .mli interfaces, but not the .ml files for modules such as Ast The [interpreter] OPAM package properly provides the .mli interfaces, but not the .ml files for modules such as Ast May 17, 2019
@rossberg rossberg changed the title The [interpreter] OPAM package properly provides the .mli interfaces, but not the .ml files for modules such as Ast [interpreter] OPAM package properly provides the .mli interfaces, but not the .ml files for modules such as Ast May 17, 2019
@rossberg
Copy link
Member

The OPAM package needs updating. I'd leave this open for now. I have tagged this [interpreter] to make clear that it doesn't affect the spec.

@binji binji added the interpreter issues that only affect the interpreter label May 22, 2019
@rossberg rossberg closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter issues that only affect the interpreter
Projects
None yet
Development

No branches or pull requests

4 participants