Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] uncovered edge cases #974

Closed
cdetrio opened this issue Feb 22, 2019 · 2 comments
Closed

[test] uncovered edge cases #974

cdetrio opened this issue Feb 22, 2019 · 2 comments
Labels
test issues that affect a test (core, js-api, or web-api)

Comments

@cdetrio
Copy link

cdetrio commented Feb 22, 2019

A comment in test/Todo.md says tests should "either be specified in Semantics.md, have a link to an open issue/PR, or be obvious." Is there a policy elsewhere for including test cases in the suite?

I'm asking because we've ran into a number of bugs in various parser and interpreter implementations, even though the implementations were passing the full spec test suite. I also wanted to open this issue to start tracking them: go-interpreter/wagon#93 go-interpreter/wagon#104 https://github.com/yurydelendik/wasmparser.rs/pull/92 (and more I can dig up later).

@binji
Copy link
Member

binji commented Feb 22, 2019

I don't think we have a more explicit policy for tests. The comment you mention sounds like it should be updated (we don't use Semantics.md anymore, for example).

That said, the tests you describe sound useful. Please feel free to open PRs to add them.

@ericprud
Copy link

@cdetrio , do you still expect to produce tests? Should this issue remain open?

@binji binji added the test issues that affect a test (core, js-api, or web-api) label May 22, 2019
@rossberg rossberg closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test issues that affect a test (core, js-api, or web-api)
Projects
None yet
Development

No branches or pull requests

4 participants