Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up wasi-crypto working group? #73

Open
rjzak opened this issue Aug 2, 2022 · 40 comments
Open

Set up wasi-crypto working group? #73

rjzak opened this issue Aug 2, 2022 · 40 comments

Comments

@rjzak
Copy link
Contributor

rjzak commented Aug 2, 2022

I'd like to propose a weekly 30-minute call to discuss wasi-crypto and synchronize efforts. We're ready to use it in Enarx, and would like to have it in a Wasi snapshot.

CC: @npmccallum, @jedisct1, @tarcieri, @sunfishcode

Refs: #69, #65, #63, #58, #56, #71

@jedisct1
Copy link
Member

jedisct1 commented Aug 2, 2022

Unless this is specifically about rust and wasmtime, @sonder-joker should obviously be here as well.

@jedisct1
Copy link
Member

jedisct1 commented Aug 2, 2022

Having representatives of common crypto libraries, as well as other webassembly runtimes involved would also probably be a good thing.

@PiotrSikora
Copy link
Contributor

I'd be interested as well, so please invite me if there is a separate meeting... But is there any reason not to have this discussion (or at least, to kick it off) in the regular bi-weekly WASI meeting?

@tarcieri
Copy link

tarcieri commented Aug 2, 2022

I'd be interested in attending a kickoff meeting. Not sure I can attend regularly though. Be happy to jump on to discuss specific issues as they come up

@rjzak
Copy link
Contributor Author

rjzak commented Aug 2, 2022

@PiotrSikora Starting off with the Wasi meeting, scheduled for 11 August, works for me.
@jedisct1 Could you tag other potentially interested parties to make them aware?

@ndevillard
Copy link

ndevillard commented Aug 3, 2022

Hi all, I would also be interested to join such a working group, if invitations are open?
We are working on a similar project: a generic C API for crypto. Hope that makes sense.

@rjzak
Copy link
Contributor Author

rjzak commented Aug 3, 2022

Is everyone part of the WebAssembly Working Group? If not, then let's not use the Wasi meeting to get started.

@jedisct1
Copy link
Member

jedisct1 commented Aug 3, 2022

In order to get some adoption, taking advantage of the crypto extension should be as simple as possible for application developers. Ideally, it should be transparent. Existing crypto libraries and APIs like the generic C API would, under the hood, use the extension when the application is compiled to WebAssembly. This is at least what we're planning to do in the Zig standard library.

So, yes, @ndevillard , your participation would be more than welcome!

@jedisct1
Copy link
Member

jedisct1 commented Aug 3, 2022

When WebAssembly signatures were discussed during WebAssembly CG meetings, my impression was that most of the participants were not specifically interested in discussing specialized topics such as crypto. Most of the discussions actually happened in a dedicated working group.

It may be the same here. A dedicated working group, with its own sessions may be more appropriate, especially to discuss algorithms or implementation details.

@jedisct1
Copy link
Member

jedisct1 commented Aug 3, 2022

Maybe @autodidaddict @tniessen @vshymanskyy @FiloSottile would like to join?

@FiloSottile
Copy link

FiloSottile commented Aug 3, 2022 via email

@linclark
Copy link
Member

linclark commented Aug 3, 2022

Is everyone part of the WebAssembly Working Group? If not, then let's not use the Wasi meeting to get started.

Unfortunately if this wants to move forward as a WASI proposal, everyone does need to be part of the WebAssembly CG. This is due to IP rules in the W3C.

I would suggest using the WASI SG meetings. We usually have space in the agenda, and other contributors can determine from the agenda whether they are interested in attending or not, so that should solve the "are we boring everyone else" issue.

@rjzak
Copy link
Contributor Author

rjzak commented Aug 3, 2022

Joining the WebAssembly Working Group can be done here: https://www.w3.org/community/webassembly/

@rjzak
Copy link
Contributor Author

rjzak commented Aug 5, 2022

Thoughts for the first meeting:

  • Finalising Wasi-Crypto so it can be in the next Wasi Snapshot.
  • Migrate Witx to Wit.
    • Seems Wasmtime Wiggle is the Witx parser, and glue to link the generated code to Wasmtime internals. Alternatives?
  • Rust Crypto vs. Boring. Options based on features?
  • Anything else?

@abrown
Copy link

abrown commented Aug 5, 2022

I'm also interested in attending.

@jedisct1
Copy link
Member

jedisct1 commented Aug 8, 2022

Would the WASI meeting on August 11 (16:00-17:00 UTC) work for everyone?

If not, the next one is on August 25.

@jedisct1
Copy link
Member

jedisct1 commented Aug 8, 2022

Seems Wasmtime Wiggle is the Witx parser, and glue to link the generated code to Wasmtime internals.
Rust Crypto vs. Boring. Options based on features?

Such discussions may be a bit out of scope, and would be better discussed directly on GitHub (and maybe implementations should have their own repo). They are about inner details of one specific implementation, not about the WASI interface itself.

Finalising Wasi-Crypto so it can be in the next Wasi Snapshot.

The spec is not finished, but we indeed need to discuss the exact set of required APIs for the first snapshot.

@rjzak
Copy link
Contributor Author

rjzak commented Aug 8, 2022

The discussions might be good to have to get people on the same page, at least initially.

As for the spec being finalised, what's missing? How does it get to be finalised ?

@npmccallum
Copy link

I'm happy with August 11. I think we should focus on organizing a working group within which we can make design decisions and track progress.

@jedisct1
Copy link
Member

jedisct1 commented Aug 9, 2022

@FiloSottile @ndevillard @PiotrSikora @sonder-joker would you be able to attend? For the first meeting, your presence would be really useful.

@PiotrSikora
Copy link
Contributor

Yes, I'll be there. Thanks for checking!

@FiloSottile
Copy link

FiloSottile commented Aug 10, 2022 via email

@sonder-joker
Copy link
Collaborator

I will attend.

@jedisct1
Copy link
Member

jedisct1 commented Aug 10, 2022

Yeah I can make that, thank you. Do we need to do something (like join the WG) to join?

Yes, you need to join here (same for you, @sonder-joker)

You then need to fill this form in order to get an invite.

@FiloSottile
Copy link

@jedisct1 ah, only saw the form now, just filled it, will join if a chair catches it :)

@npmccallum
Copy link

@jedisct1 Thanks for the talk today!

Any suggestions on day/time for a 30 minute weekly meeting?

@rjzak
Copy link
Contributor Author

rjzak commented Aug 11, 2022

I'm sorry I missed the meeting (delayed flight). Are there notes available?

@rjzak
Copy link
Contributor Author

rjzak commented Aug 19, 2022

I'm going to get started getting a weekly meeting scheduled next week.

@jedisct1
Copy link
Member

How about a biweekly meeting at 16:00 UTC on Wednesdays?

@rjzak
Copy link
Contributor Author

rjzak commented Aug 22, 2022

I thought maybe the Zulip chat might be easier for communicating than comments on a Github issue, so I created #wasi-crypto and invited some people.

@rjzak
Copy link
Contributor Author

rjzak commented Aug 22, 2022

I propose we have a recurring bi-weekly meeting Tuesday at 16:00 UTC, 12:00 Eastern, 09:00 Pacific starting next Tuesday, 30 August. Does that work?
https://meet.google.com/moe-zwuu-hag

Google Calendar: https://calendar.google.com/event?action=TEMPLATE&tmeid=MzdlaGNzdDczM2Y4NmtrOHVscHJrNXJpNWNfMjAyMjA4MzBUMTYwMDAwWiByaWNoYXJkLnpha0Bwcm9maWFuLmNvbQ&tmsrc=richard.zak%40profian.com&scp=ALL

@abrown
Copy link

abrown commented Aug 22, 2022

I believe that conflicts with the WebAssembly CG meeting but if it were pushed a week it would work?

@rjzak
Copy link
Contributor Author

rjzak commented Aug 22, 2022

@abrown I have that on my calendar as being on Thursdays. Is that incorrect?

@abrown
Copy link

abrown commented Aug 23, 2022

I think so? I remember there was some confusion with the calendar invites over the last few months so perhaps one of us has the wrong version. I suspect I have the right one because I have been attending the CG for the last few months without issue.

(...looking this up to see if I can confirm either way)

Yeah, it looks like the CG meetings are on the same Tuesdays as proposed above; see the CG meeting list, the next of which is on August 30th.

@rjzak
Copy link
Contributor Author

rjzak commented Aug 23, 2022

Okay, let's start 6 September. I think I was confused with CG vs. WG.

@rjzak
Copy link
Contributor Author

rjzak commented Aug 24, 2022

Could we have these Wasi-Crypto meetings added to the WebAssembly/meetings page?

@rjzak
Copy link
Contributor Author

rjzak commented Aug 24, 2022

@bstrie

@jedisct1
Copy link
Member

We didn't had meetings for a while due to the host not being present.

@rjzak were you the host? Can you edit the Google calendar entry? Or shall we create a new meeting, possibly with more hosts in order to avoid this issue?

@rjzak
Copy link
Contributor Author

rjzak commented Mar 15, 2023

@jedisct1 You (or someone with a more permanent involvement with the project) should re-create the event. The event was in my Google Calendar, which won't last much longer.

@jedisct1
Copy link
Member

jedisct1 commented Mar 17, 2023

Thank you @rjzak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

11 participants