-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Popover API #74
Comments
As raised in whatwg/html#7785 (comment) I don't think pop-up (with a hyphen) works. |
Thanks for the reply! Let's continue the naming discussion on the PR, and find a good solution. Would it then be fair to say that once we resolve the naming question, you're supportive of this feature? |
No, it's still under discussion. |
Ok, makes sense, thanks! But in that case, I think we should wait to work on the naming question until you've had a chance to more thoroughly review and discuss the feature. Otherwise, we could spend significant time/effort trying to rename the attribute only to find there are other blockers. Or even find that we need to rename it back, based on later findings. So please feel free to reach out with other questions! |
Colleagues and I had another look and we're quite happy with the recent changes:
Also thanks to @domenic for helping flush some of that out. The main thing we're not quite sure about (but unfortunately also don't have a suggestion for at the moment) is the tight integration with Web Animations for hiding. Is that motivated somewhere and why it doesn't similarly apply to other elements with state transitions? Other than that we're largely positive on this feature now. |
Awesome, thanks for the feedback! I'm glad you're happy with the changes and the general shape of the API. The feedback we've received via the HTML spec PR have been very helpful in general, and has led to most of these changes.
So the animation behavior (discussed at length here) is definitely a cool feature that developers want, and it's something missing from e.g. I'm not sure if your question was about the need to animate, or just the particulars of how it works with Web Animations. In case it's the latter, the technical need is to wait (somehow) for animations to complete before hiding the popover and removing it from the top layer. And it's important to also be able to capture existing animations on the element, to avoid waiting for things that weren't triggered by the show/hide action. The most natural way to do both of these seemed to be via the Web Animations API. If there's a better way to do that, I'd love to hear suggestions!
Thanks! 🎉 |
@annevk per my comment just now, we've ripped out the animations stuff from the Popover spec PR. We very much want to support animations for popovers, but we think we can do it a) independently, and b) in a more general way to support things other than popover. Your comment seemed to indicate that this animations stuff was your last remaining hesitation about this feature. With it gone, would you be willing to officially mark this standards-position as Supportive? |
Yeah, although there's still a number of issues with the PR they are relatively minor so I would suggest we label this as "position: support" on December 21. |
Closing as we've identified our position. |
Request for position on an emerging web specification
Information about the spec
Design reviews and vendor positions
Bugs tracking this feature
Brief summary of the issue or the subject of the spec.
A very common UI pattern on the Web, for which there is no native API, is "pop up UI" or "pop-ups". Pop-ups are a general class of UI that have three common behaviors:
The Pop-Up API aims to make this type of UI easy to build.
The text was updated successfully, but these errors were encountered: