Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in RevIN for POTS data #453

Closed
1 of 2 tasks
WenjieDu opened this issue Jul 2, 2024 · 0 comments
Closed
1 of 2 tasks

Bug in RevIN for POTS data #453

WenjieDu opened this issue Jul 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@WenjieDu
Copy link
Owner

WenjieDu commented Jul 2, 2024

1. System Info

PyPOTS v0.6

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

As shown below, for POTS data case, x = x / self.stdev is not applied.

else:
# pypots implementation for POTS data
missing_sum = (
torch.sum(missing_mask == 1, dim=dim2reduce, keepdim=True) + 1e-9
)
self.mean = torch.sum(x, dim=dim2reduce, keepdim=True) / missing_sum
x = x - self.mean
x_enc = x.masked_fill(missing_mask == 0, 0)
variance = torch.sum(x_enc * x_enc, dim=dim2reduce, keepdim=True) + 1e-9
self.stdev = torch.sqrt(variance / missing_sum)

4. Expected behavior

Normalization process has not been finished for POTS data case.

@WenjieDu WenjieDu added the bug Something isn't working label Jul 2, 2024
@WenjieDu WenjieDu self-assigned this Jul 2, 2024
@WenjieDu WenjieDu closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant