Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unintended saving success when model file already exists #515

Closed
1 of 2 tasks
WenjieDu opened this issue Sep 19, 2024 · 0 comments
Closed
1 of 2 tasks

Unintended saving success when model file already exists #515

WenjieDu opened this issue Sep 19, 2024 · 0 comments
Assignees
@WenjieDu
Labels
bug Something isn't working

Comments

@WenjieDu
Copy link
Owner

1. System Info

v0.8 and all previous

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

Log error but do not quit operation, and this results in unintended overwrite saving when model file already exists

https://github.com/WenjieDu/PyPOTS/blob/main/pypots/base.py#L290-L294

4. Expected behavior

Still save the model though logging error.

2024-09-19 07:58:05 [ERROR]: ❌ File testing_results/models/imputation/SAITS/20240919_T075803/SAITS.pypots exists. Saving operation aborted. Use the arg `overwrite=True` to force overwrite.
2024-09-19 07:58:05 [INFO]: Saved the model to testing_results/models/imputation/SAITS/20240919_T075803/SAITS.pypots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WenjieDu WenjieDu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WenjieDu