feat(picking): change trigger pick event from pointdown to pointtap

to solve "if inspector->transform->blur in canvas, not undo" bug
Wonder-Technology · Jan 20, 2019 · dd10f12 · dd10f12
1 parent b649cc5
commit dd10f12
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/core/utils/engine/job/init/initPickingJob/InitPickingJobUtil.re b/src/core/utils/engine/job/init/initPickingJob/InitPickingJobUtil.re
@@ -254,7 +254,7 @@ let _handlePicking = (event: EventType.customEvent, engineState) => {
 let initJob = (_, engineState) => {
   let engineState =
     ManageEventEngineService.onCustomGlobalEvent(
-      ~eventName=EventEditorService.getPointDownEventName(),
+      ~eventName=EventEditorService.getPointTapEventName(),
       ~handleFunc=
         (. event, engineState) =>
           MouseEventService.isLeftMouseButton(event) ?

diff --git a/test/integration/job/initPickingJob_test.re b/test/integration/job/initPickingJob_test.re
@@ -15,7 +15,7 @@ let _ =
 
     describe("test find picked one", () => {
       describe("should set finded one to current scene tree node", () => {
-        describe("if pointdown->mouse button isn't left button", () => {
+        describe("if pointtap->mouse button isn't left button", () => {
           let _prepare = () =>
             InitPickingJobTool.prepareOneGameObject(
               ~sandbox,

diff --git a/test/integration/job/tool/InitPickingJobTool.re b/test/integration/job/tool/InitPickingJobTool.re
@@ -239,6 +239,17 @@ let triggerPicking = (sandbox, pageX, pageY, eventButton) => {
       (),
     ),
   );
+  EventTool.triggerDomEvent(
+    "click",
+    EventTool.getBody(),
+    MouseEventTool.buildMouseEvent(
+      ~pageX,
+      ~pageY,
+      ~target,
+      ~which=eventButton,
+      (),
+    ),
+  );
 };
 
 let triggerPickingAndRestore = (~eventButton=1, ~sandbox, ~pageX, ~pageY, ()) => {