Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPCS 3.0: Remove the deprecated Sniff::has_whitelist_comment() method #1583

Closed
jrfnl opened this issue Dec 21, 2018 · 4 comments · Fixed by #1908
Closed

WPCS 3.0: Remove the deprecated Sniff::has_whitelist_comment() method #1583

jrfnl opened this issue Dec 21, 2018 · 4 comments · Fixed by #1908
Assignees
Milestone

Comments

@jrfnl
Copy link
Member

jrfnl commented Dec 21, 2018

PR #1580 for WPCS 2.0.0 deprecated the WPCS native whitelist comments and the associated Sniff::has_whitelist_comment() method.

In WPCS 3.0.0 this method and all calls to it should be removed.

Note: all unit tests testing that the WPCS native whitelist comments are being respected should also be removed at that time. Or alternatively, they can remain and it should be verified that the WPCS native whitelist comment makes no difference anymore.

@kkmuffme
Copy link

Is there any possibility of this getting released? Since the has_whitelist_comment function is quite slow

@jrfnl
Copy link
Member Author

jrfnl commented May 22, 2022

@kkmuffme It will be released as part of WPCS 3.0.0.

@kkmuffme
Copy link

It's been multiple years since this PR was merged, which is why I asked :-)

@jrfnl
Copy link
Member Author

jrfnl commented May 22, 2022

I am fully aware (though it's actually not been multiple years yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants