Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPCS 3.0.0: Remove deprecated WP.TimezoneChange sniff #1819

Closed
jrfnl opened this issue Oct 27, 2019 · 5 comments · Fixed by #1909
Closed

WPCS 3.0.0: Remove deprecated WP.TimezoneChange sniff #1819

jrfnl opened this issue Oct 27, 2019 · 5 comments · Fixed by #1909
Assignees
@jrfnl
Labels
Type: Chores/Cleanup
Milestone
3.0.0

Comments

@jrfnl
Copy link
Member

jrfnl commented Oct 27, 2019

As per the proposal in #1805, the WordPress.WP.TimezoneChange sniff has been deprecated in PR #1807 / WPCS 2.2.0.

In the next major release of WPCS (3.0.0), this sniff should be removed.
@jrfnl jrfnl added this to the 3.0.0 milestone Oct 27, 2019
@jrfnl jrfnl changed the title Remove deprecated WP.TimezoneChange sniff WPCS 3.0.0: Remove deprecated WP.TimezoneChange sniff Oct 27, 2019
@paulschreiber
Copy link
Contributor

Seeing this now. It's creating a lot of noise.

@jrfnl
Copy link
Member Author

jrfnl commented Jan 3, 2020

@paulschreiber Unless the sniff is explicitly included in a custom ruleset, you shouldn't see any noise coming from this....

@paulschreiber
Copy link
Contributor

I'm seeing it via the PHPCompatibilityWP ruleset.

@jrfnl
Copy link
Member Author

jrfnl commented Jan 3, 2020

@paulschreiber That's not possible as the PHPCompatibilityWP ruleset is completely unrelated to WPCS and does not include any WPCS sniffs.

@jrfnl jrfnl mentioned this issue Apr 1, 2020
Closed
19 tasks
@paulschreiber
Copy link
Contributor

Turns out to be a problem with VIP Go's ruleset.

@WordPress WordPress deleted a comment from paulschreiber Apr 8, 2020
@jrfnl jrfnl self-assigned this Apr 10, 2020
@jrfnl jrfnl mentioned this issue Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrfnl jrfnl

Labels
Type: Chores/Cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

3.0: Remove the WordPress.WP.TimezoneChange sniff WordPress/WordPress-Coding-Standards
2 participants
@paulschreiber @jrfnl