-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Blueprint Metadata for Blueprints Gallery v1 #3
Comments
|
@ironnysh they could update that Blueprint via a PR, I wonder if explicitly the keeping track of the version number buys us anything here. |
Hey @adamziel, I might be missing something 😀 Here's the scenario I imagined:
My questions:
|
It would be replaced by the new one. The previous version would still be available via git history.
The newest version. Do you think exposing both could be useful?
Git commit messages would form one, perhaps we could associate a CHANGELOG.md file with each Blueprint and update it automatically with a PR title and link on each change 🤔 I wonder what would it be useful for, though. |
@ironnysh just pinging to follow up :-) |
Oh, sorry, I must've missed the notification on this one :-)
I guess it depends on how extensive are the changes to the Blueprints.
Thinking about a future situation, when people use Blueprints from the gallery in their live projects: Does that make sense? |
@ironnysh oh interesting! This touches a deeper issue – should we use permalinks or link to the latest version of Blueprints and their related resources.
I am leaning towards generally recommending the first one, but documenting the second one as a possible choice if the reader is okay with the downsides.
My thinking was we could GitHub history for that as it provides a list of changes, their description, time of commit, and author, e.g. here: https://github.com/adamziel/blueprints/commits/trunk/blueprints/posts-via-wp-cli/blueprint.json |
I like it. +1 :-)
Yes, definitely. And the format/workflow will be what you mentioned above?
|
Version numbers for blueprints don't seem to have a particular purpose except for historical value. My understanding is that the blueprints in the gallery are just examples that people will copy, modify and to their needs. Even if two months from now, I update one of the examples, the earlier usage is disconnected from the new version anyway. It's not like an npm dependency, or a plugin dependency that could cause havoc when updated over the network. So I agree that the commit history should be enough to follow up on historical information. I would actually tend to opt for the second variation, the /trunk/ as that's. the official current version of the blueprint. It also helps creators to have a consistent way to link to think. The link is fully understandable, and doesn't include a random string in the middle of it. Readability is a value to to be underestimated. I would have that as a default setting and if someone using the blueprints wants to use the gallery version in their projects for good, it's their responsibility to keep up with changes, like with any other dependency they add to their technical debt. Using the /trunk/ links would also be consistent with other directory usage of the asset that also go back to the /trunk/ version, and everything in the directory of a blueprint uses the same link pattern: As example: All assets are referenced in the -- |
Glad you joined in, @bph, awesome points! :-)
I believe this is the core difference: I was thinking about the Blueprint Gallery as the equivalent of the Themes/Plugins directory, while your perspective is closer to the Patterns directory. In this case, using
Good point. I haven't thought of that.
Whichever model we end up with, it's crucial to communicate it and make sure people understand the pros and cons of each option. |
A lot of great points here, that's perfect! It seems like we're good to close this issue and move forward with Title, Description, Author, and Categories as the initial metadata fields, and we can always add new ones once they won't be sufficient.
@bph would you please make a note of this in the contributing documentation? Thank you! |
What metadata is useful to keep track of? For now we have:
Would Blueprint version, similar to a plugin version, be useful at all? I'm not sure. Semantic versioning, as in
0.1.17
makes sense for software packages, but it doesn't seem to make sense for Blueprints. Also, contrary to plugins, there is nothing to auto-update after a new Blueprint is released.The text was updated successfully, but these errors were encountered: