This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Add focusable=false to the generated SVG markup (needed for Gutenberg) #224
Comments
Which file needs to be edited? I'm trying to figure out where focusable="false" goes... |
At the end of the react/index.jsx file? |
This was fixed in a previous PR. Should be all set... |
@field2 hi, unfortunately seems the following PR removed it: https://github.com/WordPress/dashicons/pull/226/files there's no |
Ping 🙂 This issue should be reopened. |
OK, added it again. Please review and make sure everything's up to date. |
Thx! looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello everyone. In Gutenberg, we've just merged a fix for an IE 11 bug, see WordPress/gutenberg#2590
More details on the PR and the related issue WordPress/gutenberg#1578
The fix is as simple as adding
focusable="false"
to prevent IE 11 giving focus to the icons.I guess this fix should be ported here too 🙂
The text was updated successfully, but these errors were encountered: