From 4ccf920c333eb4d474125758bb2dcae8deab04f4 Mon Sep 17 00:00:00 2001 From: Chip Snyder Date: Wed, 19 Feb 2020 17:22:19 -0500 Subject: [PATCH] Revert "Add API for Logging User Events in gutenberg-mobile and iOS" This reverts commit d6f0c5b54cf91aa18648bd5ccc78a720a22c0b47. --- gutenberg | 2 +- react-native-gutenberg-bridge/index.js | 8 -------- .../ios/GutenbergBridgeDelegate.swift | 10 ---------- .../ios/RNReactNativeGutenbergBridge.m | 1 - .../ios/RNReactNativeGutenbergBridge.swift | 6 ------ 5 files changed, 1 insertion(+), 26 deletions(-) diff --git a/gutenberg b/gutenberg index 67a36f387d5e4..5870cafa74aee 160000 --- a/gutenberg +++ b/gutenberg @@ -1 +1 @@ -Subproject commit 67a36f387d5e4f7828e4c25fe5f89743a839412e +Subproject commit 5870cafa74aee22b1c59c26451561a722c769c73 diff --git a/react-native-gutenberg-bridge/index.js b/react-native-gutenberg-bridge/index.js index b3d9ae3e45368..f8ff33fc1b3bc 100644 --- a/react-native-gutenberg-bridge/index.js +++ b/react-native-gutenberg-bridge/index.js @@ -16,10 +16,6 @@ export const mediaSources = { siteMediaLibrary: 'SITE_MEDIA_LIBRARY', }; -export const userEvents = { - pageTemplateApplied: 'page_template_applied', -}; - export const showMediaEditorButton = isIOS; // Console polyfill from react-native @@ -122,8 +118,4 @@ export function fetchRequest( path ) { return RNReactNativeGutenbergBridge.fetchRequest( path ); } -export function logUserEvent( event, properties ) { - return RNReactNativeGutenbergBridge.logUserEvent( event, properties ); -} - export default RNReactNativeGutenbergBridge; diff --git a/react-native-gutenberg-bridge/ios/GutenbergBridgeDelegate.swift b/react-native-gutenberg-bridge/ios/GutenbergBridgeDelegate.swift index a3635e1bca8dc..ee0e161ba2e9b 100644 --- a/react-native-gutenberg-bridge/ios/GutenbergBridgeDelegate.swift +++ b/react-native-gutenberg-bridge/ios/GutenbergBridgeDelegate.swift @@ -64,10 +64,6 @@ extension RCTLogLevel { } } -public enum GutenbergUserEvent: String { - case pageTemplateApplied = "page_template_applied" -} - public protocol GutenbergBridgeDelegate: class { /// Tells the delegate that Gutenberg had returned the requested HTML content. /// You can request HTML content by calling `requestHTML()` on a Gutenberg bridge instance. @@ -142,12 +138,6 @@ public protocol GutenbergBridgeDelegate: class { /// Tells the delegate to display the media editor from a given URL /// func gutenbergDidRequestMediaEditor(with mediaUrl: URL, callback: @escaping MediaPickerDidPickMediaCallback) - - - /// Tells the delegate that the editor needs to log a custom event - /// - Parameter event: The event key to be logged - /// - Parameter properties: Any relevant properties related to the event - func gutenbergLogUserEvent(_ event: GutenbergUserEvent, properties: [AnyHashable: Any]) } // MARK: - Optional GutenbergBridgeDelegate methods diff --git a/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m b/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m index 5eead641e4882..73430cf1dd37d 100644 --- a/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m +++ b/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m @@ -18,6 +18,5 @@ @interface RCT_EXTERN_MODULE(RNReactNativeGutenbergBridge, NSObject) RCT_EXTERN_METHOD(fetchRequest:(NSString *)path resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) RCT_EXTERN_METHOD(requestImageFullscreenPreview:(NSString *)currentImageUrlString originalImageUrlString:(NSString *)originalImageUrlString) RCT_EXTERN_METHOD(requestMediaEditor:(NSString *)mediaUrl callback:(RCTResponseSenderBlock)callback) -RCT_EXTERN_METHOD(logUserEvent:(NSString *)event properties:(NSDictionary *)properties) @end diff --git a/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift b/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift index 462ebe311288c..e09ba4c0e0f93 100644 --- a/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift +++ b/react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift @@ -224,12 +224,6 @@ public class RNReactNativeGutenbergBridge: RCTEventEmitter { self.sendEvent(withName: name, body: body) } } - - @objc - func logUserEvent(_ event: String, properties:[AnyHashable: Any]?) { - guard let event = GutenbergUserEvent(rawValue: event) else { return } - self.delegate?.gutenbergLogUserEvent(event, properties: properties ?? [:]) - } } // MARK: - RCTBridgeModule delegate