Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit links to open in external window in Gutenberg #10088

Closed
coxconsultancy opened this issue Sep 21, 2018 · 3 comments
Closed

Cannot edit links to open in external window in Gutenberg #10088

coxconsultancy opened this issue Sep 21, 2018 · 3 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@coxconsultancy
Copy link

There is a problem when setting up/editing a link to open in an external window. It occasionally works but more often just goes round in circles and closes the window.

  • Clicking on the 3 dots and then the open in new window button closes the window without making the change.
  • Clicking on the pencil and then the open in new window button does the same.

Using Chrome 68 on Windows 10 on a PC.
Wordpress 4.9.8 and Listing Pro Theme.

@talldan talldan added the [Type] Bug An existing feature does not function as intended label Sep 21, 2018
@talldan
Copy link
Contributor

talldan commented Sep 21, 2018

Hi @coxconsultancy - Thanks for the report. I couldn't reproduce the issue with the toggle not saving its value when I tested, but it might be because I'm on a Mac. It definitely seems like a bug and usability issue that it hides as soon as clicked!
toggle

I also noticed that sometimes the autocomplete dropdown from the url input can overlap the toggle.

@saulirajala
Copy link

I was not either able to replicate the issue with toggle value not saving, but I also tested with Mac.

#7890 seemed to fix the usability issue (link settings hides immediately after toggle-button is clicked) partially and #10372 will fix the rest. This is how it looks like with #10372 :
link-open-in-new-window

@mtias
Copy link
Member

mtias commented Nov 12, 2018

Thanks for the report! Closing as unable to reproduce in latest versions. Please, reopen if it's still happening.

@mtias mtias closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants