Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEXT COLOR #10225

Closed
goyakpacking opened this issue Sep 28, 2018 · 6 comments
Closed

TEXT COLOR #10225

goyakpacking opened this issue Sep 28, 2018 · 6 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.

Comments

@goyakpacking
Copy link

goyakpacking commented Sep 28, 2018

Ease of changing Text Color is too cumbersome.

Problem: We have several sites that use a selected blue font color from the tool bar. That blue color is used throughout our sites for LINK colors. Theme TwentySeventeen. When creating a link in TwentySeventeen [to do several changes with ease] the sequence is click the tool bar LINK icon, paste the link in the drop down box, click enter to save the link. While the text is still highlighted, click the BOLD icon on the tool bar, then click the TEXT COLOR icon drop down, then click one of the specific default chart blue colors [#0000ff] we have been using.

That creates the Link, makes the text bold, and colors it blue, all in a few clicks in the same area.

When we attempt this with Gutenberg, first; the text color change option does not appear in the tool bar above the block we are working on, were the LINK icon is located.

Off to the right side in some of the options we can change the text color, but the default choice of color in the colored button selection, does not match the TwentySeventeen Theme color defaults.

That makes us create a different colored text, unless diving farther in, with more steps, and steps at different locations on the screen.

Suggestion. Mimic the two rows of tool bar functions found in the TwentySeventeen Theme. Further, Mimic the default color chart found there, so they are the same between Gutenberg Editor, and the Classic Editor. Your Plugin requires too many steps to get the desired effect. Edit Functions are in different locations [i.e the Tool bar above the Block, and the Options on the left side], The default color selection mismatching is especially troublesome for someone working on an existing site.

Os Win7 64 Bit
Browser Firefox 62.0 (64-bit)
Gutenberg 3.9.0

@Soean
Copy link
Member

Soean commented Sep 28, 2018

Related issue: Need of TextColor for inline formatting #6080

@Soean Soean added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Backwards Compatibility Issues or PRs that impact backwards compatability labels Sep 28, 2018
@joyously
Copy link

Changing text colors in posts and pages SHOULD be difficult. It should be a rare case, not something you do a lot.

Changing link color in the theme should be easy. Changing the theme to one with different link colors or with different options to change link colors should be easy.

And changing the link color in the theme (or changing the theme) should change the whole site, so having unique ones in posts/pages might clash with the new choice and you'd have to revisit each post/page to fix it. This is not best practice or recommended.

@chris11049
Copy link

Thanks for the judgement on what should or should not be difficult. I disagree entirely with the need to change colors (in links and outside of links), so if someone could actually address the question with an answer I would be thrilled. I wasn't searching for what someone else deems best practice, that would be a different search.

@ellatrix
Copy link
Member

The plugin Advanced Rich Text Tools will now add inline text and background color controls. This is plugin territory, we won't add it to WordPress Core at this time.

@phpbits
Copy link
Contributor

phpbits commented May 17, 2019

I've also added text highlighting color options on EditorsKit plugin ( https://wordpress.org/plugins/block-options/ ) and I hope this solves this problem. Here's how my implementation works :

Gutenberg Highlighted Text and Background Colors

@goyakpacking
Copy link
Author

goyakpacking commented May 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants