Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While dragging a block, upwards scrolling of the page is hindered by notice message #10239

Closed
kalnode opened this issue Sep 28, 2018 · 2 comments
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks Needs Testing Needs further testing to be confirmed.

Comments

@kalnode
Copy link

kalnode commented Sep 28, 2018

Description
Using Gutenberg 3.9.0

While dragging a block on a very long page, upwards scrolling of the page is hindered by notice messages inside the Gutenberg editor. I have to manually press "x" on the notice message to be able to drag blocks upwards on a long page. The presence of the notice message doesn't allow for scrolling to trigger when the dragging-cursor enters the same region.

To Reproduce
Steps to reproduce the behavior:

  1. Start with a test page, filled with enough random blocks and content so that there's lots of scrolling needed.
  2. Scroll down to the bottom of the page in the Gutenberg editor window; for convenience make sure there's a small block there.
  3. Invoke a notice message to appear. The easiest is just pressing "Update" (in the case of updating a published page).
  4. The notice message appears, e.g. "Post updated! View post". It's a colored bar at the top of the editor window, with an "x" to close it.
  5. Try dragging a block upwards to a much higher spot on the page. The notice message doesn't allow for page scrolling to be triggered. You have to stop your train of thought, let go of the block you carefully selected (especially if it's within nested block), manually close the notice message then start the block dragging process over again.

Expected behavior
Many people would perhaps expect or desire for drag-induced page scrolling to act normally even with a notice bar in the way. Maybe the notice bar can fade-out slightly when a dragging-cursor enters the region. In any case, it is annoying to have to mentally stop what you're doing (dragging a block) to deal with a notice bar (which 99% of the time is just an affirmation message).

Desktop:

  • OS: Macos 10.13.6
  • Browser: Chrome
  • Version: 62.0

Using Gutenberg 3.9.0

@designsimply designsimply added Needs Testing Needs further testing to be confirmed. [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Oct 1, 2018
@shoelaced
Copy link

I came to post that drag-scroll didn't work at all but discovered it does when I manually closed the notice as described above. What I would add is that it would be helpful if dragging over the top toolbar would also scroll the page, because as it currently works, you have to drag exactly over the tiny area right on the bottom edge of the top toolbar in order to get it to scroll.

@youknowriad
Copy link
Contributor

I just tested this again and a few things have changed:

  • These notices are used less (we use snackbars as alternatives)
  • I didn't reproduce the issue with or without the notice

That said, I think drag and drop is still not great, it's hard to get the page to scroll. I think these should be addressed with rethinking how drag and drop works (efforts like #16457)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

4 participants