Blue circle hover effects on top of arrows

[paaljoachim]

I am testing: https://testgutenberg.wpkonsulterna.se/wp-admin/admin.php?page=gutenberg

I believe this is already a part of an existing issue but I can not locate it right now.

Initially hovering over the left arrow beside the text block the up arrow is barely seen greyed out and the down arrow is obvious to notice.
I click to move the block one step down.
I click to move it up again.
This time there is a blue circle around the greyed out up button.

To me the blue circle feels out of place. The up arrow is already greyed out showing that one can not move it further up. Hmm hovering over the down arrow the blue circle is now also visible. Instead of having a blue circle what about just having the arrows turn blue?

As one hovers over the arrows one can see a more subtile change.

[jasmussen]

The blue circle is the focus highlight. I agree that it should show up only when you are using keyboard input, and not on button press. Though whether this is a bug or not, is part of a larger discussion that is ongoing in #904 (comment). For that reason, I'm closing this one. But thank you for reporting it as an issue.

[afercia]

This is also because the up arrow in this case is not really "disabled", it just looks disabled. Adding a disabled attribute when it's... disabled, would make it not focusable -> no focus style. If I remember correctly, this is already mentioned in another issue.

[jasmussen]

Was the disabled aspect not fixed in #228 ? @iseulde any insights? Thank you.

[ellatrix]

@jasmussen I'm not sure what you're asking. The ticket you're linking was a prototype ticket.

[jasmussen]

Argh, I'm having a case of the mondays. Nevermind me. I could just swear we had a ticket somewhere for actually adding a disabled attribute to the up/down arrows when they are at the top or bottom of the block list.

[aduth]

#984 was somewhat related, though to labeling the buttons, not applying the disabled attribute.