Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-uniform behaviour of Text formatting shortcuts #11544

Closed
tybor opened this issue Nov 6, 2018 · 4 comments
Closed

Non-uniform behaviour of Text formatting shortcuts #11544

tybor opened this issue Nov 6, 2018 · 4 comments
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@tybor
Copy link

tybor commented Nov 6, 2018

Describe the bug
Monospaced and strikethrough shortcuts behave differently than bold or italics. Ideally all text formatting shortcuts shall behave in the same manner. Monospace and strikethrough instead require the user to type the part that shall be monospaced, stop typing, select the freshly typed text that shall be monospaced, use the shortcut. This breaks the workflow. The same does not hold for bold, italic and underline.

To Reproduce
Steps to reproduce the behavior:

  1. in the editor hit Ctrl-B and type "some text"
  2. then hit Alt-Shift-X and type "print('Hello Dolly!');"

Expected behavior
The expected code should be <strong>some text <code>print('Hello Dolly!');</code></strong>
Currently one gets <strong>some text print('Hello Dolly!');</strong>

Screenshots
Not applicable

Desktop:

  • OS: Linux
  • Browser Firefox
  • Version 63.0.1

Additional context

  • Gutenberg 4.1.1
@ellatrix
Copy link
Member

ellatrix commented Nov 6, 2018

Duplicated of #11065. This will be fixed in 4.2.

@ellatrix ellatrix closed this as completed Nov 6, 2018
@tybor
Copy link
Author

tybor commented Nov 6, 2018

Duplicated of #11065. This will be fixed in 4.2.

Thanks.
I'm sorry for the duplicate, I did looked for something similar, obviously failing... :)

@tybor
Copy link
Author

tybor commented Nov 6, 2018

@iseulde I want to test the development version. git cloning the repo into wordpress/wp-content/plugins is enough or there's a specific way to do this?

@ellatrix
Copy link
Member

ellatrix commented Nov 6, 2018

Have a look at https://github.com/WordPress/gutenberg/blob/master/CONTRIBUTING.md to run the dev version.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants