Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getCurrentRichTextSelection to use blockSelection start&end blocks #11615

Closed
atimmer opened this issue Nov 8, 2018 · 3 comments
Closed
Assignees
Labels
[Feature] Annotations Adding annotation functionality [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.

Comments

@atimmer
Copy link
Member

atimmer commented Nov 8, 2018

Spinning out from #7718.

For getCurrentRichTextSelection, @youknowriad mentioned that we could reuse the block selection already present in blockSelection. This issue tracks that.

@atimmer atimmer added [Type] Enhancement A suggestion for improvement. [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Package] Editor /packages/editor labels Nov 8, 2018
@atimmer atimmer self-assigned this Nov 8, 2018
@atimmer atimmer mentioned this issue Nov 8, 2018
4 tasks
@omarreiss omarreiss added the [Feature] Annotations Adding annotation functionality label Mar 26, 2019
@ellatrix
Copy link
Member

ellatrix commented Apr 4, 2019

@atimmer How is this different form #11616?

@atimmer
Copy link
Member Author

atimmer commented Apr 4, 2019

It was different back when my PR still contained a global state for RichText selection. I had created two issues to track different issues:

#14640 seems to do both in one fell swoop, so I'll close this issue.

@atimmer atimmer closed this as completed Apr 4, 2019
@ellatrix
Copy link
Member

ellatrix commented Apr 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Annotations Adding annotation functionality [Feature] Plugins API Extending the Gutenberg project with plugins via the Plugins API [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants