Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the selected block outline darker #12254

Closed
afercia opened this issue Nov 23, 2018 · 4 comments
Closed

Make the selected block outline darker #12254

afercia opened this issue Nov 23, 2018 · 4 comments
Assignees
@kjellr
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Nov 23, 2018

As agreed on #11737 the selected block outline should be darker. For non-text contrast (user interface components) the WCAG level AA contrast requirement is at least 3:1.

Right now, the outline uses a very light grey color that is barely visible for users who need it the most, especially when there are no other indicators for the selected block:

focus after
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Nov 23, 2018
@afercia
Copy link
Contributor Author

afercia commented Nov 23, 2018

Note: for light themes, $dark-opacity-200 would be OK. Not sure what color to use for dark themes.

@timwright12 timwright12 mentioned this issue Nov 30, 2018
Closed
@timwright12
Copy link
Contributor

timwright12 commented Nov 30, 2018 •
edited
Loading

Grabbed this one (via @10up)

@afercia afercia mentioned this issue Jan 18, 2019
Closed
@afercia
Copy link
Contributor Author

afercia commented Jan 18, 2019

Related #12088 (duplicate).

@ZebulanStanphill ZebulanStanphill mentioned this issue Jan 29, 2019
Closed
@kjellr kjellr mentioned this issue Feb 25, 2019
Closed
This was referenced Feb 26, 2019
Open
Closed
This was referenced Feb 27, 2019
Merged
Closed
@kjellr
Copy link
Contributor

kjellr commented Mar 15, 2019

Closing now that #14145 has merged. 👍

@kjellr kjellr closed this as completed Mar 15, 2019
@mapk mapk mentioned this issue May 2, 2019
Closed
@afercia afercia mentioned this issue Jul 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjellr kjellr

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timwright12 @kjellr @afercia