Confusing editor mode switching (Visual/Code Editor)

[webmandesign]

Description

Options to switch between "Visual Editor" and "Code Editor" mode are pretty confusing. They basically work like radio buttons, however, the checkmark icon sets expectation they would work the same way as, for example, the "Top Toolbar" option, which is basically a toggle button (a checkbox).

Expected behavior

Not sure whether "Visual Editor" option is even needed. Could there only be a "Code Editor" option that works like a toggle button?

Video

https://www.dropbox.com/s/aw2x03xjjwja1u3/gutenberg-editor-mode-switching.mp4

Additional context

• Gutenberg v4.5.1
• Tested at https://wordpress.org/gutenberg/

[swissspidy]

Not sure how well a toggle button would work accessibility-wise. Just so that it won‘t be forgotten.

[webmandesign]

Yes, accessibility is also my concern.
But I'm coming from presumption that those already included toggle buttons ("Top Toolbar" option, for example) are accessible. So, implementing similar functionality for editor mode switcher shouldn't be a problem(?).

[mapk]

An additional benefit for keeping them as they are is it helps with terminology. If we eliminate the "Visual editor" choice, people begin to call it all sorts of things.

[Nobiuss]

Hi,

I understand the confusions about this because the look is the same and they don't act the same.
Maybe it is best if there would be some kind of a switch for the visual or code editor.
I will add a mockup for this, how it can look.

Kind regards,
Kim

[afercia]

Worth reminding the "More" dropdown is an ARIA menu, and as such can contain exclusively items of type menuitem, menuitemcheckbox, menuitemradio.

[mapk]

I'm taking another look at how the Code Editor might work as a whole in this other issue:
#17017

Chances are, it will affect this issue too.

[youknowriad]

Is this still an issue? As raised by @afercia The Menu is an aria menu that only contains menu items (with their keyboard interactions).

[webmandesign]

Well, for me I can still see the issue simply from user experience perspective. But it's up to you guys what works best. I'd appreciate the toggle button or something similar, but if it's not implemented, I will deal with current state of the things :)

[youknowriad]

I'm going to close this as works as intended. While I appreciate the opinion, we still need to make this good a11y wise and it seems that the dropdown being an aria menu is the way to go.